bump controller-runtime to 0.23.0 #6080

andriisoldatenko · 2026-01-23T08:39:03Z

Description

Similar to #6053 but includes changes to fix CI.

Note

controller-runtime has breaking changes more details https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.23.0

DAQ-20001

How can this be tested?

unit-test/ e2e tests where we can check webhooks.

migration of new events API requires proper testing

pkg/api/latest/dynakube/dynakube_webhook.go

pkg/api/validation/edgeconnect/validation.go

avorima · 2026-01-26T10:06:46Z

I think we should slow down a bit here. This isn't the only thing that this release introduces and we should take a step back and evaluate. This can serve as a kick-off for more broader changes to the structure and layout of the project.

If the dependency update is this pressing, I'd prefer if we keep the changes minimal by continuing to use the CustomValidator.

andriisoldatenko · 2026-01-26T10:29:41Z

I think we should slow down a bit here. This isn't the only thing that this release introduces and we should take a step back and evaluate. This can serve as a kick-off for more broader changes to the structure and layout of the project.

If the dependency update is this pressing, I'd prefer if we keep the changes minimal by continuing to use the CustomValidator.

Release introduces a few breaking changes:

Webhooks: Generic Validator and Defaulter by in #3360
- Existing code of the form builder.WebhookManagedBy(mgr).For(&corev1.Deployment{}) has to be changed to builder.WebhookManagedBy(mgr, &appsv1.Deployment{})
- Existing webhook implementations have to be changed to take the concrete object rather than runtime.Object, for example from ValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error) to ValidateCreate(ctx context.Context, obj *appsv1.Deployment) (admission.Warnings, error)
Events: Migration to the new events API in #3262
Using the new GetEventRecorderFor requires updating your rbac for events to use the events.k8s.io apiGroup rather than the `` (core) apiGroup

~~This one I'm working on right now~~ done in the latest commits.

andriisoldatenko · 2026-01-26T10:49:36Z

pkg/api/validation/dynakube/databases.go

 )

-func missingDatabaseExecutorImage(_ context.Context, _ *Validator, dk *dynakube.DynaKube) string {
+func missingDatabaseExecutorImage(_ context.Context, _ *validatorClient, dk *dynakube.DynaKube) string {


NB (for reviwer):

we can also rename validator to validatorType or something similar

type validator[T DynaKubeType] struct { *validatorClient }

and validatorClient back to Validator to reduce amount of changes in this PR

avorima

missing RBAC for events.k8s.io

avorima · 2026-01-27T13:31:01Z

pkg/api/validation/dynakube/proxy_url.go

 )

-func invalidActiveGateProxyURL(ctx context.Context, dv *Validator, dk *dynakube.DynaKube) string {
+func invalidActiveGateProxyURL(ctx context.Context, dv *validatorClient, dk *dynakube.DynaKube) string {


rename variable to vc to stay consistent. also in

pkg/api/validation/dynakube/telemetryservice.go
pkg/api/validation/dynakube/validation.go
pkg/api/validation/edgeconnect/validation.go

avorima · 2026-01-27T13:34:37Z

pkg/api/validation/dynakube/validation.go

 )

-type Validator struct {
+type DynaKubeType interface {


this was aleady mentioned in a previous discussion, but specialization doesn't really do much at the cost of having to be kept up-to-date. the getDynaKube function already checks the type at runtime and it's very obvious when you use a non-supported type

avorima · 2026-01-27T13:37:10Z

pkg/api/validation/dynakube/validation.go

-type validatorFunc func(ctx context.Context, dv *Validator, dk *dynakube.DynaKube) string
-type updateValidatorFunc func(ctx context.Context, dv *Validator, oldDk *dynakube.DynaKube, newDk *dynakube.DynaKube) string
+type validatorFunc func(ctx context.Context, dv *validatorClient, dk *dynakube.DynaKube) string
+type updateValidatorFunc func(ctx context.Context, dv *validatorClient, oldDk *dynakube.DynaKube, newDk *dynakube.DynaKube) string


nit

Suggested change

type updateValidatorFunc func(ctx context.Context, dv *validatorClient, oldDk *dynakube.DynaKube, newDk *dynakube.DynaKube) string

type updateValidatorFunc func(ctx context.Context, dv *validatorClient, oldDk, newDk *dynakube.DynaKube) string

avorima · 2026-01-27T13:39:07Z

pkg/api/validation/dynakube/webhook.go

-	if err := v1beta5.SetupWebhookWithManager(mgr, validator); err != nil {
+	v1beta5Validator := newGenericValidator[*v1beta5.DynaKube](validatorImpl)
+	if err := ctrl.NewWebhookManagedBy(mgr, &v1beta5.DynaKube{}).
+		WithValidator(v1beta5Validator). // will create an endpoint at /validate-dynatrace-com-v1beta4-dynakube


comments don't reference the correct endpoint. i think it's a sign that they can be removed

am i miss something https://github.com/dynatrace/dynatrace-operator/blob/e205376d3a8311335687b073d498462e0c5f9421/config/helm/chart/default/templates/Common/webhook/validatingwebhookconfiguration.yaml#L27

avorima · 2026-01-27T13:40:15Z

pkg/api/validation/edgeconnect/module.go

 )

-func isModuleDisabled(_ context.Context, v *Validator, _ *edgeconnect.EdgeConnect) string {
+func isModuleDisabled(_ context.Context, v *validatorClient, _ *edgeconnect.EdgeConnect) string {


vc to stay consistent

avorima · 2026-01-27T13:45:35Z

pkg/api/validation/dynakube/webhook.go


 func SetupWebhookWithManager(mgr ctrl.Manager) error {
-	validator := New(mgr.GetAPIReader(), mgr.GetConfig())
+	validatorImpl := newClient(mgr.GetAPIReader(), mgr.GetConfig())


please align dynakube and edgeconnect validation packages. i prefer the way it's done in edgeconnect since it's more concise

validatorClient

newValidator instead of newGenericValidator and just call it inline in WithValidator

I'm aware of it - i'll fix it!

andriisoldatenko · 2026-01-27T17:08:37Z

#6104

bump controller-runtime to 0.23.0

3235ec7

github-actions bot added the edgeconnect Changes related to EdgeConnect label Jan 23, 2026

undo redundunt change

826aac9

Incredible-O added dependencies Changes in our dependencies and removed edgeconnect Changes related to EdgeConnect labels Jan 23, 2026

0sewa0 reviewed Jan 26, 2026

View reviewed changes

pkg/api/latest/dynakube/dynakube_webhook.go Outdated Show resolved Hide resolved

Fix validator's generic mess

747ec5c

github-actions bot added the edgeconnect Changes related to EdgeConnect label Jan 26, 2026

andriisoldatenko commented Jan 26, 2026

View reviewed changes

pkg/api/validation/edgeconnect/validation.go Show resolved Hide resolved

andriisoldatenko commented Jan 26, 2026

View reviewed changes

pkg/api/validation/edgeconnect/validation.go Show resolved Hide resolved

andriisoldatenko added 3 commits January 26, 2026 10:39

fixup linters

d066ae7

Merge branch 'main' into bump-controller-runtime-0-23

b245b3e

Apply marcell's idea wtih DynaKubeType

520ed6d

andriisoldatenko added 2 commits January 26, 2026 11:39

migrate events to new API

bd74d7b

use T

712e8c5

andriisoldatenko marked this pull request as ready for review January 26, 2026 10:43

andriisoldatenko requested a review from a team as a code owner January 26, 2026 10:43

andriisoldatenko requested review from 0sewa0, Edivion, Incredible-O, StefanHauth, aorcholski, avorima and waodim January 26, 2026 10:43

andriisoldatenko commented Jan 26, 2026

View reviewed changes

andriisoldatenko removed the edgeconnect Changes related to EdgeConnect label Jan 26, 2026

Merge branch 'main' into bump-controller-runtime-0-23

bca9608

github-actions bot added the edgeconnect Changes related to EdgeConnect label Jan 27, 2026

avorima self-assigned this Jan 27, 2026

avorima reviewed Jan 27, 2026

View reviewed changes

andriisoldatenko mentioned this pull request Jan 27, 2026

bump controller-runtime from 0.22.x to 0.23.1 #6104

Merged

andriisoldatenko closed this Jan 27, 2026

	type updateValidatorFunc func(ctx context.Context, dv validatorClient, oldDk dynakube.DynaKube, newDk *dynakube.DynaKube) string
	type updateValidatorFunc func(ctx context.Context, dv validatorClient, oldDk, newDk dynakube.DynaKube) string

bump controller-runtime to 0.23.0 #6080

bump controller-runtime to 0.23.0 #6080

Uh oh!

Conversation

andriisoldatenko commented Jan 23, 2026 • edited by avorima Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How can this be tested?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avorima commented Jan 26, 2026

Uh oh!

andriisoldatenko commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avorima left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andriisoldatenko commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andriisoldatenko commented Jan 23, 2026 •

edited by avorima

Loading

andriisoldatenko commented Jan 26, 2026 •

edited

Loading