Skip to content

Remove pry require from production releases #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-e merged 5 commits into from
Jan 13, 2025
Merged

Remove pry require from production releases #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68618c0
Remove pry require from production releases
trevor-e Jan 13, 2025
e3591f6
Add imagemagick explicitly
trevor-e Jan 13, 2025
19fd4f6
test
trevor-e Jan 13, 2025
05a5b2b
woops
trevor-e Jan 13, 2025
9749e9d
Merge branch 'main' into telkins/remove-pry
trevor-e Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/cli_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3.3'
ruby-version: "3.3.3"
bundler-cache: true

- name: Run Rubocop
Expand All @@ -29,7 +29,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
ruby-version: ['3.3.3']
ruby-version: ["3.3.3"]
runs-on: ${{ matrix.os }}

steps:
Expand Down Expand Up @@ -60,9 +60,19 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3.3'
ruby-version: "3.3.3"
bundler-cache: true

- name: Install dependencies
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
sudo apt-get update
sudo apt-get install -y imagemagick
Copy link
Collaborator Author

@trevor-e trevor-e Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like Github no longer includes imagemagick by default on its runners, so have to manually install. CI for this PR originally failed.

elif [ "$RUNNER_OS" == "macOS" ]; then
brew install imagemagick
fi
shell: bash

- name: Create test images directory
run: |
mkdir -p test/fixtures/snapshots
Expand Down
1 change: 0 additions & 1 deletion lib/emerge_cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
require_relative 'utils/version_check'

require 'dry/cli'
require 'pry-byebug'

module EmergeCLI
extend Dry::CLI::Registry
Expand Down
Loading