Skip to content

Conversation

@j-mes
Copy link
Member

@j-mes j-mes commented Nov 27, 2025

Describe your changes

Additional context

JIRA ticket Figma design
OR-xxxx Figma: Name

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@frshwtr frshwtr marked this pull request as ready for review January 8, 2026 15:08
@frshwtr frshwtr requested a review from a team as a code owner January 8, 2026 15:08
@joelcarr joelcarr requested a review from Copilot January 8, 2026 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds form validation functionality based on the Constraint Validation API, including automated error handling, inline feedback, and error summaries.

  • Implements a validation system using the Constraint Validation API with support for custom error messages
  • Adds visual feedback for invalid form fields with inline error messages and an error summary component
  • Creates comprehensive test coverage for validation behavior across different user interactions

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
components/o3-form/stories/formValidation.test.stories.tsx Test suite validating error display, error summary, and progressive validation behavior
components/o3-form/stories/formValidation.stories.tsx Storybook story demonstrating the form validation feature
components/o3-form/stories/FormValidationHtml.tsx HTML template component with test data for validation demonstrations
components/o3-form/src/tsx/fieldComponents/Form.tsx Adds optional id prop to Form component
components/o3-form/src/js/validation.js Core validation logic with error collection, inline feedback, and error summary rendering
components/o3-form/src/css/components/error-summary.css Fixes CSS class name typo from o3-forms__error-summary__list to o3-form__error-summary__list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frshwtr and others added 4 commits January 9, 2026 11:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@frshwtr frshwtr requested a review from Copilot January 12, 2026 14:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frshwtr and others added 3 commits January 13, 2026 11:02
…g escaping or encoding

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
The issue came down to browsers rendering different text for the same errors. Short term fix for now is to assert on both error messages
@frshwtr frshwtr requested a review from Copilot January 13, 2026 16:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frshwtr and others added 4 commits January 13, 2026 16:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@j-mes
Copy link
Member Author

j-mes commented Jan 20, 2026

@frshwtr @joelcarr I can't approve this, see screenshot.

image

It all looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants