Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 2, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Migrates feature settings, feature value and create feature to typescript components
  • Migrates Row / FormGroup to fix imports
  • Simplifies interface around the create feature modal, this will eventually mean the RTK/redux store no longer needs to create new objects
    • Editing project/feature related stuff is adjusting the ProjectFlag with a single onChange
    • Editing the remote config, enabled state and MV percentages is adjusting a FeatureState with a single on Chnange
  • Minor: add tag button same height as tags
image

How did you test this code?

E2E covers regression testing on everything this affects

kyle-ssg and others added 30 commits August 5, 2025 16:27
# Conflicts:
#	frontend/web/components/pages/UserPage.tsx
@talissoncosta
Copy link
Contributor

talissoncosta commented Jan 20, 2026

QA Plan ENV V2

  • I can enable/disable my flag
  • I can update the value of my flag
  • I can update the value of a MV option
  • I can update the weight of a MV option
  • I can create a MV option
  • I can delete a MV option
  • I can add a feature to a release pipeline - 🟠 (all good on the 1st time, fail on 2nd time)
  • I can remove a feature from a release pipeline - 🟠 (all good on the 1st time)
  • I can create a Feature specific segment
  • I can attach a Feature specific segment
  • I can attach an existing segment
  • I can disable all segment
  • I can save my segments
  • I am redirected to user page if I want to edit an identity - 🟠
  • I can delete an identity - 🟠
  • I can add/remove a tag to my flag
  • I can update a custom field on my feature
  • I can assign/remove users
  • I can assign/remove groups
  • I can add a description
  • I can enable/disabled server side
  • I can archive/unarchive my flag

Getting an error on add to Release Pipeline when try to add the feature for the 2nd time. ( not sure if this is relevant)
image
image

Identity overrides is showing blank page
image

@talissoncosta
Copy link
Contributor

talissoncosta commented Jan 20, 2026

QA Plan ENV V2 + CR

  • I can enable/disable my flag
  • I can update the value of my flag
  • I can update the value of a MV option
  • I can update the weight of a MV option
  • I can create a MV option
  • I can delete a MV option
  • I can add a feature to a release pipeline - 🟠 (all good on the 1st time, fail on 2nd time)
  • I can remove a feature from a release pipeline - 🟠 (all good on the 1st time)
  • I can create a Feature specific segment
  • I can attach a Feature specific segment
  • I can attach an existing segment
  • I can disable all segment
  • I can save my segments
  • I am redirected to user page if I want to edit an identity - 🟠
  • I can delete an identity - 🟠
  • I can add/remove a tag to my flag
  • I can update a custom field on my feature
  • I can assign/remove users
  • I can assign/remove groups
  • I can add a description
  • I can enable/disabled server side
  • I can archive/unarchive my flag

Same issues for identity overrides and RP

Copy link
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve noticed some unusual behavior during the QA session and would like to clarify it before moving forward.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@talissoncosta
Copy link
Contributor

V1 not requesting CR to update segment overrides

https://www.loom.com/share/e75ccdbd4dc044ec94942da76daa2a32

@kyle-ssg kyle-ssg merged commit 00085cd into main Jan 20, 2026
27 checks passed
@kyle-ssg kyle-ssg deleted the chore/create-flag-migration branch January 20, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants