Skip to content

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jan 19, 2026

Changes

Closes to #6548

Verifies that the deployment successfully updated the task definition before exiting the workflow successfully.

How did you test this code?

Added current branch to deploy to staging temporarily (see here).

@matthewelwell matthewelwell requested a review from a team as a code owner January 19, 2026 13:25
@matthewelwell matthewelwell requested review from talissoncosta and removed request for a team January 19, 2026 13:25
@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 19, 2026 5:27pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 19, 2026 5:27pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Jan 19, 2026 5:27pm

Request Review

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jan 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6549 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6549 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6549 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6549 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6549 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6549 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6549 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6549 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6549 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6549 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6549 Finished ✅ Results

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.09%. Comparing base (e2e77b0) to head (0b67c6b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6549   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files        1293     1293           
  Lines       46610    46610           
=======================================
  Hits        45722    45722           
  Misses        888      888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! Couple blockers.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 19, 2026
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 19, 2026
@matthewelwell
Copy link
Contributor Author

The latest failure (here) was because of a concurrency issue. I've added concurrency checks to the deployment jobs too.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 19, 2026
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 19, 2026
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 19, 2026
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 19, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

with:
environment: staging
secrets: inherit
concurrency:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking: is there any reason why this is defined at job level rather than workflow?

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants