Merged
Conversation
bhalsey
reviewed
Apr 16, 2025
wied03
approved these changes
Apr 17, 2025
spwitt
commented
Apr 18, 2025
| </APIField> | ||
| <APIField name="logins[x].loginId" type="String"> | ||
| The email or username of the user. Because email or username may be modified after the login event occurred, only the <InlineField>userId</InlineField> and the should be considered immutable for historical purposes when identifying the user. | ||
| The identity used to log in. Because an identity may be modified after the login event occurred, only the <InlineField>userId</InlineField> should be considered immutable for historical purposes when identifying the user. |
Contributor
Author
There was a problem hiding this comment.
We now store the identity info in the raw_logins table when the login can be tied to a specific identity
- If the identity info is stored with the login record, it will reflect the value used when the login occurred
- If the login record does not have identity information, it will behave as before and look up the value from the database
- Is that acceptable behavior? I can’t think of a way around it.
- How far into the weeds do we want to go describing the behavior in docs?
Contributor
There was a problem hiding this comment.
I think this is good enough
bhalsey
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document changes to login records that affect login record search and export APIs.