Skip to content

Add independent scaling fields (hyperdisk) to GA #13949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hao-nan-li merged 1 commit into from
May 14, 2025
Merged

Add independent scaling fields (hyperdisk) to GA #13949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions mmv1/products/netapp/StoragePool.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ description: |
the next apply. You can trigger a manual
[zone switch](https://cloud.google.com/netapp/volumes/docs/configure-and-use/storage-pools/edit-or-delete-storage-pool#switch_active_and_replica_zones)
via Terraform by swapping the value of the `zone` and `replica_zone` parameters in your HCL code.
Note: Custom Performance FLEX storage pools are supported in beta provider currently.

references:
guides:
Expand Down Expand Up @@ -187,14 +186,11 @@ properties:
description: |
Optional. True if using Independent Scaling of capacity and performance (Hyperdisk). Default is false.
immutable: true
min_version: 'beta'
- name: 'totalThroughputMibps'
type: String
description: |
Optional. Custom Performance Total Throughput of the pool (in MiB/s).
min_version: 'beta'
- name: 'totalIops'
type: String
description: |
Optional. Custom Performance Total IOPS of the pool If not provided, it will be calculated based on the totalThroughputMibps
min_version: 'beta'
10 changes: 2 additions & 8 deletions mmv1/third_party/terraform/services/netapp/resource_netapp_storage_pool_test.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ data "google_compute_network" "default" {
`, context)
}

{{ if ne $.TargetVersionName `ga` -}}
func TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update(t *testing.T) {
context := map[string]interface{}{
"network_name": acctest.BootstrapSharedServiceNetworkingConnection(t, "gcnv-network-config-2", acctest.ServiceNetworkWithParentService("netapp.servicenetworking.goog")),
Expand All @@ -327,7 +326,7 @@ func TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update(t

acctest.VcrTest(t, resource.TestCase{
PreCheck: func() { acctest.AccTestPreCheck(t) },
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
CheckDestroy: testAccCheckNetappStoragePoolDestroyProducer(t),
Steps: []resource.TestStep{
{
Expand Down Expand Up @@ -355,7 +354,6 @@ func TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update(t
func testAccNetappStoragePool_customPerformanceStoragePoolCreateExample_full(context map[string]interface{}) string {
return acctest.Nprintf(`
resource "google_netapp_storage_pool" "test_pool" {
provider = google-beta
name = "tf-test-pool%{random_suffix}"
location = "us-east4-a"
service_level = "FLEX"
Expand All @@ -368,7 +366,6 @@ resource "google_netapp_storage_pool" "test_pool" {
}

data "google_compute_network" "default" {
provider = google-beta
name = "%{network_name}"
}
`, context)
Expand All @@ -377,7 +374,6 @@ data "google_compute_network" "default" {
func testAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update(context map[string]interface{}) string {
return acctest.Nprintf(`
resource "google_netapp_storage_pool" "test_pool" {
provider = google-beta
name = "tf-test-pool%{random_suffix}"
location = "us-east4-a"
service_level = "FLEX"
Expand All @@ -390,9 +386,7 @@ resource "google_netapp_storage_pool" "test_pool" {
}

data "google_compute_network" "default" {
provider = google-beta
name = "%{network_name}"
}
`, context)
}
{{ end }}
}
Loading