feat(bigtable): rename instance to instance_name for table_iam resource

[ron-gal]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigtable: renamed instance to instance_name for bigtable_table_iam objects

fixes hashicorp/terraform-provider-google#7939

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 32 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 4 files changed, 32 insertions(+), 32 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field instance within resource google_bigtable_table_iam_binding was either removed or renamed - reference
• Field instance within resource google_bigtable_table_iam_member was either removed or renamed - reference
• Field instance within resource google_bigtable_table_iam_policy was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_binding" "primary" {
  instance_name = # value needed
}

Resource: google_bigtable_table_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_member" "primary" {
  instance_name = # value needed
}

Resource: google_bigtable_table_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_policy" "primary" {
  instance_name = # value needed
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_bigtable_table_iam_binding
  • Expected Document Path: /website/docs/r/bigtable_table_iam.html.markdown
  • Fields: [instance_name]
• google_bigtable_table_iam_member
  • Expected Document Path: /website/docs/r/bigtable_table_iam.html.markdown
  • Fields: [instance_name]
• google_bigtable_table_iam_policy
  • Expected Document Path: /website/docs/r/bigtable_table_iam.html.markdown
  • Fields: [instance_name]

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 0
Skipped tests: 55
Affected tests: 0

Click here to see the affected service packages

• bigtable

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 33 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 4 files changed, 33 insertions(+), 33 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field instance within resource google_bigtable_table_iam_binding was either removed or renamed - reference
• Field instance within resource google_bigtable_table_iam_member was either removed or renamed - reference
• Field instance within resource google_bigtable_table_iam_policy was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_binding" "primary" {
  instance_name = # value needed
}

Resource: google_bigtable_table_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_member" "primary" {
  instance_name = # value needed
}

Resource: google_bigtable_table_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_policy" "primary" {
  instance_name = # value needed
}

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 0
Skipped tests: 55
Affected tests: 0

Click here to see the affected service packages

• bigtable

🟢 All tests passed!

View the build log

[ScottSuarez]

Hello, this is a breaking change and can only be made during a major release.

[ScottSuarez]

Could you add an upgrade guide entry.
https://googlecloudplatform.github.io/magic-modules/breaking-changes/make-a-breaking-change/#:~:text=Add%20the%20upgrade%20guide%20entries

[ron-gal]

Could you add an upgrade guide entry. https://googlecloudplatform.github.io/magic-modules/breaking-changes/make-a-breaking-change/#:~:text=Add%20the%20upgrade%20guide%20entries

Done.

[ScottSuarez]

stub for tests

https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_BIGTABLE/402972

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 51 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 5 files changed, 51 insertions(+), 33 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field instance_name added as required on pre-existing resource google_bigtable_table_iam_binding - reference
• Field instance_name added as required on pre-existing resource google_bigtable_table_iam_member - reference
• Field instance_name added as required on pre-existing resource google_bigtable_table_iam_policy - reference
• Field instance within resource google_bigtable_table_iam_binding was either removed or renamed - reference
• Field instance within resource google_bigtable_table_iam_member was either removed or renamed - reference
• Field instance within resource google_bigtable_table_iam_policy was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_binding" "primary" {
  instance_name = # value needed
}

Resource: google_bigtable_table_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_member" "primary" {
  instance_name = # value needed
}

Resource: google_bigtable_table_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table_iam_policy" "primary" {
  instance_name = # value needed
}

Errors

google-beta provider:

• Failed to detect subcategory in the frontmatter in file website/docs/guides/version_7_upgrade.html.markdown.

[modular-magician]

Tests analytics

Total tests: 59
Passed tests: 0
Skipped tests: 59
Affected tests: 0

Click here to see the affected service packages

• bigtable

🟢 All tests passed!

View the build log

[c2thorn]

just noting we ran into an issue with the 7.0.0 branch and needed to recreate this PR here: #14436

Nothing else should be needed, just FYI