Skip to content

Sync feature branch resource identity#14374

Closed
BBBmau wants to merge 476 commits intoGoogleCloudPlatform:FEATURE-BRANCH-resource-identityfrom
BBBmau:sync-FEATURE-BRANCH-resource-identity
Closed

Sync feature branch resource identity#14374
BBBmau wants to merge 476 commits intoGoogleCloudPlatform:FEATURE-BRANCH-resource-identityfrom
BBBmau:sync-FEATURE-BRANCH-resource-identity

Conversation

@BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Jun 25, 2025 •
edited
Loading

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

melinath and others added 30 commits May 20, 2025 22:32
@melinath
Removed colab schedule post_create logic related to setting name (Goo…
7245e5e 
…gleCloudPlatform#13965)
@Berro321
Add google_beyondcorp_security_gateway_application resource. (Googl…
dec1fdc 
…eCloudPlatform#13918)
@iyabchen
Add a copy file header to state the source file for handwritten files (…
9fb2d49 
…GoogleCloudPlatform#13725)
@osela
Add PSC fields to Filestore instance in beta (GoogleCloudPlatform#13883)
d971f7b
@slevenick
Update membership_data.go (GoogleCloudPlatform#14044)
d290b6a
@Samir-Cit
Fix TestAccContainerNodePool_resourceManagerTags (GoogleCloudPlatform…
c722c3a 
…#13994)
@BBBmau
resourceIdentity: set nightlyTestsEnabled to false (GoogleCloud…
f641484 
…Platform#14055)
@trodge
Combine all post replay templates into one (GoogleCloudPlatform#13958)
534cbed
@kigesui
Adding Apigee Security Monitoring Condition resource support (GoogleC…
e56f4d2 
…loudPlatform#13714)

Co-authored-by: Meng Yang <mengyang@google.com>
@zli82016
Suppress the diff for false value of force_attach field (GoogleCloudP…
78268de 
…latform#14057)
@AshwinGururagh
Allow updates to the mtu property in the Network resource. (GoogleClo…
a6159af 
…udPlatform#13995)
@amfisher-404 @slevenick
Add Managed Kafka Acl resource and tests. (GoogleCloudPlatform#14034)
8fe07d5 
Co-authored-by: Sam Levenick <slevenick@google.com>
@mihhalj
Promote firewall policy with rules resources to GA (GoogleCloudPlatfo…
ae3f8d0 
…rm#13546)
@gbidkar
container: add emphasis of service account attribute reference in docs (
341dffb 
GoogleCloudPlatform#14020)
@ramonvermeulen
feat: google_iam_workforce_pool_provider_key resource creation (Goo…
708cd78 
…gleCloudPlatform#13842)
@Dawid212
Add Mirror Percent to request_mirror_policy in URLMAP (GoogleCloudPla…
3c26542 
…tform#13974)
@ScottSuarez
source service API and service package for all 99% of TGC resources (G…
8ae4f86 
…oogleCloudPlatform#14045)
@shuyama1
Unskip TestAccNetworkSecurityGatewaySecurityPolicyRule_multiple (Goog…
8381d3c 
…leCloudPlatform#14037)
@ScottSuarez
refactor more templates that no longer need to be (GoogleCloudPlatfor…
abc6d28 
…m#14060)
@ScottSuarez
Convert review functions to go-gh (GoogleCloudPlatform#14031)
aaabc87
@YpNo
gkehub: datasource for gke_hub_membership resource (GoogleCloudPlatfo…
807a5d4 
…rm#13915)
@ScottSuarez
Enable mmv1 unit tests to run on main and all paths (GoogleCloudPlatf…
6255c20 
…orm#14063)
@ScottSuarez @melinath
Extend breaking change detector to work on new required and new optio…
29dd6c8 
…nal with default (GoogleCloudPlatform#14059)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@ramonvermeulen
feat: added google_bigquery_table data source (GoogleCloudPlatform#…
2a6c3c8 
…14026)
@melinath
Update enrolled_teams.yml (GoogleCloudPlatform#14065)
9a70e2b
@sahil-mahajan-google
Add Onprem Migration fields to Volume and Replication (GoogleCloudPla…
7d587e1 
…tform#14039)
@kautikdk
Adds IP Filter feature support to google_storage_bucket resource. (Go…
dc332fe 
…ogleCloudPlatform#14002)
@harshithpatte-g
fix documentation of mtu field in interconnect attachments resource (G…
01b8438 
…oogleCloudPlatform#14053)
@stevenyang72
Add workload identity pool managed identity. (GoogleCloudPlatform#14048)
5c95074
@shuyama1
Add vacation for shuyama1 (GoogleCloudPlatform#14017)
865fa30
@zli82016
Copy link
Member

zli82016 commented Jun 27, 2025

@BBBmau, checks still failed. Is it expected?

@srichaitanyab @melinath
Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)
1e00d9f 
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@BBBmau
Copy link
Collaborator Author

BBBmau commented Jun 27, 2025 •
edited
Loading

@BBBmau, checks still failed. Is it expected?

ah the failing TGC tests come from go.mod being included in the tgc_next, we'll want to open a new PR that handles the SDK/v2 bump.

We don't see failures in the FEATURE-BRANCH due to the branch not having a dedicated go.mod for tgcnext which was introduced May 15 right after the last sync PR

@zli82016
Copy link
Member

zli82016 commented Jun 27, 2025

Thanks for the information.

The errors for tgc unit tests are as the following

Error: tfplan2cai/tfdata/fake_resource_data.go:48:19: undefined: schema.IdentityData
Error: tfplan2cai/tfdata/fake_resource_data.go:56:48: undefined: schema.IdentityData
# github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgresource
Error: ../tpgb/google-beta/tpgresource/resource_test_utils.go:38:30: undefined: schema.IdentityData
Error: ../tpgb/google-beta/tpgresource/resource_test_utils.go:93:48: undefined: schema.IdentityData
Error: ../tpgb/google-beta/tpgresource/utils.go:63:22: undefined: schema.IdentityData
Error: ../tpgb/google-beta/tpgresource/utils.go:241:25: cannot use d (variable of type *"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema".ResourceData) as TerraformResourceData value in argument to ExpandStringMap: *"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema".ResourceData does not implement TerraformResourceData (missing method Identity)

But this PR Manage go.mod and go.sum of tgc doesn't generate any diffs. I don't get that these errors are related to the tgc PR. I remember I saw these errors before.

Should the new PR that handles the SDK/v2 bump be merging before the current PR?

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 27, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2584 files changed, 95597 insertions(+), 10205 deletions(-))
google-beta provider: Diff ( 2629 files changed, 93212 insertions(+), 10237 deletions(-))
terraform-google-conversion: Diff ( 109 files changed, 12609 insertions(+), 638 deletions(-))
Open in Cloud Shell: Diff ( 163 files changed, 5169 insertions(+), 223 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@BBBmau BBBmau force-pushed the sync-FEATURE-BRANCH-resource-identity branch 11 times, most recently from 5348c78 to 6d9dd95 Compare June 27, 2025 23:32
@BBBmau BBBmau force-pushed the sync-FEATURE-BRANCH-resource-identity branch from 1029bcb to 036c9f3 Compare June 27, 2025 23:45
@modular-magician
Copy link
Collaborator

modular-magician commented Jun 28, 2025

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeEnvironment_apigeeEnvironmentClientIpResolutionConfigTestExample
  • TestAccApigeeSecurityMonitoringCondition_apigeeSecurityMonitoringConditionBasicTestExample
  • TestAccApihubCuration_apihubCurationBasic_Update
  • TestAccBackupDRBackupPlanAssociation_fullUpdate
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition
  • TestAccBigtableTable_testTableWithRowKeySchema
  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolGcsVolume
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMountGcsExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMountNfsExample
  • TestAccComposerEnvironment_withEncryptionConfigComposer2
  • TestAccDataflowFlexTemplateJob_workerPoolsFallback
  • TestAccGKEHub2ScopeRBACRoleBinding_gkehubScopeRbacCustomRoleBindingBasicExample_update
  • TestAccGKEHubFeature_Rbacrolebindingactuation

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update
  • TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeNetworkFirewallPolicyWithRules_update
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_update
  • TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyGpuTopologyExample
  • TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyAcceleratorTopologyExample
  • TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyExample
  • TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyMaxTopologyDistanceExample
  • TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyExample
  • TestAccContainerCluster_withFlexStart
  • TestAccContainerCluster_withPodAutoscaling
  • TestAccContainerNodePool_withFlexStart
  • TestAccDNSManagedZone_privateForwardingWithDomainNameUpdate

Tests analytics

Total tests: 5322
Passed tests: 4622
Skipped tests: 588
Affected tests: 112

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 112 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_level_condition
  • TestAccAccessContextManager__access_level_full
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_update
  • TestAccAccessContextManager__service_perimeters
  • TestAccAlloydbDatabaseClusterDatasourceConfig
  • TestAccAlloydbDatabaseInstanceDatasourceConfig
  • TestAccComposerEnvironmentAirflow2_withRecoveryConfig
  • TestAccComposerEnvironmentComposer2_private
  • TestAccComposerEnvironmentComposer3_basic
  • TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
  • TestAccComposerEnvironmentComposer3_upgrade_expectError
  • TestAccComposerEnvironment_composerV2MasterAuthNetworks
  • TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate
  • TestAccComposerEnvironment_customBucketWithUrl
  • TestAccComposerEnvironment_maintenanceWindowUpdate
  • TestAccComposerEnvironment_withMaintenanceWindow
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeAutoscaler_multicondition
  • TestAccComputeAutoscaler_scaleDownControl
  • TestAccComputeAutoscaler_scaleInControl
  • TestAccComputeAutoscaler_scaleInControlFixed
  • TestAccComputeAutoscaler_scalingSchedule
  • TestAccComputeAutoscaler_update
  • TestAccComputeBackendService_withBackend
  • TestAccComputeBackendService_withBackendAndIAP
  • TestAccComputeBackendService_withBackendAndPreferenceExternalManaged
  • TestAccComputeBackendService_withBackendAndPreferenceInternalManaged
  • TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged
  • TestAccComputeBackendService_withMaxConnections
  • TestAccComputeBackendService_withMaxConnectionsPerInstance
  • TestAccComputeFirewallPolicyRule_basic
  • TestAccComputeFirewallPolicyRule_disabled_enabled
  • TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample
  • TestAccComputeFirewallPolicyRule_firewallPolicyRuleNetworkScopeExample
  • TestAccComputeFirewallPolicyRule_multipleRules
  • TestAccComputeFirewallPolicyRule_securityProfileGroup_update
  • TestAccComputeFirewallPolicyRule_update
  • TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample
  • TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample
  • TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample
  • TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample
  • TestAccComputeGlobalForwardingRule_internalLoadBalancing
  • TestAccComputeInstance_attachedDiskUpdate
  • TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputePerInstanceConfig_removeInstanceOnDestroy
  • TestAccComputePerInstanceConfig_statefulIps
  • TestAccComputePerInstanceConfig_update
  • TestAccComputeRegionBackendService_subsettingUpdate
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendMultiNic
  • TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccComputeRouterNatAddress_withAddressCountDecrease
  • TestAccComputeRouterNatAddress_withAddressRemoved
  • TestAccComputeRouterNatAddress_withAutoAllocateAndAddressRemoved
  • TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withMultiNicNetworkConfig
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withNodeConfigScopeAlias
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccDataSourceGoogleComputeInstanceGroupManager
  • TestAccDataSourceGoogleComputeInstanceGroup_fromIGM
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
  • TestAccDataplexDatascanIamPolicyGenerated
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccInstanceGroupManager_autoHealingPolicies
  • TestAccInstanceGroupManager_basic
  • TestAccInstanceGroupManager_resourceManagerTags
  • TestAccInstanceGroupManager_self_link_unique
  • TestAccInstanceGroupManager_stateful
  • TestAccInstanceGroupManager_stoppedSuspendedTargetSize
  • TestAccInstanceGroupManager_targetSizeZero
  • TestAccInstanceGroupManager_update
  • TestAccInstanceGroupManager_versions
  • TestAccInstanceGroupManager_waitForStatus
  • TestAccLoggingFolderSettings_update
  • TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections
  • TestAccMemorystoreInstance_memorystoreInstanceFullExample
  • TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update
  • TestAccNetappStoragePool_storagePoolCreateExample
  • TestAccNetappStoragePool_storagePoolCreateExample_update
  • TestAccNotebooksInstanceIamPolicyGenerated
  • TestAccNotebooksInstance_create_gpu
  • TestAccNotebooksInstance_create_vm_image
  • TestAccNotebooksInstance_notebookInstanceBasicExample
  • TestAccPrivatecaCertificateTemplateIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 28, 2025

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccAlloydbDatabaseClusterDatasourceConfig [Debug log]
TestAccAlloydbDatabaseInstanceDatasourceConfig [Debug log]
TestAccComposerEnvironmentAirflow2_withRecoveryConfig [Debug log]
TestAccComposerEnvironmentComposer3_upgrade_expectError [Debug log]
TestAccComposerEnvironment_customBucketWithUrl [Debug log]
TestAccComposerEnvironment_maintenanceWindowUpdate [Debug log]
TestAccComposerEnvironment_withMaintenanceWindow [Debug log]
TestAccComputeAutoscaler_autoscalerBasicExample [Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample [Debug log]
TestAccComputeAutoscaler_multicondition [Debug log]
TestAccComputeAutoscaler_scaleDownControl [Debug log]
TestAccComputeAutoscaler_scaleInControl [Debug log]
TestAccComputeAutoscaler_scaleInControlFixed [Debug log]
TestAccComputeAutoscaler_scalingSchedule [Debug log]
TestAccComputeAutoscaler_update [Debug log]
TestAccComputeBackendService_withBackend [Debug log]
TestAccComputeBackendService_withBackendAndIAP [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceExternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged [Debug log]
TestAccComputeBackendService_withMaxConnections [Debug log]
TestAccComputeBackendService_withMaxConnectionsPerInstance [Debug log]
TestAccComputeFirewallPolicyRule_basic [Debug log]
TestAccComputeFirewallPolicyRule_disabled_enabled [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleNetworkScopeExample [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update [Debug log]
TestAccComputeFirewallPolicyRule_update [Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample [Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample [Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample [Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing [Debug log]
TestAccComputeInstance_attachedDiskUpdate [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputePerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccComputePerInstanceConfig_statefulIps [Debug log]
TestAccComputePerInstanceConfig_update [Debug log]
TestAccComputeRegionBackendService_subsettingUpdate [Debug log]
TestAccComputeRegionBackendService_withBackendInternal [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Debug log]
TestAccComputeRouterNatAddress_withAddressCountDecrease [Debug log]
TestAccComputeRouterNatAddress_withAddressRemoved [Debug log]
TestAccComputeRouterNatAddress_withAutoAllocateAndAddressRemoved [Debug log]
TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_resourceManagerTags [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withMultiNicNetworkConfig [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withNodeConfigScopeAlias [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_fromIGM [Debug log]
TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample [Debug log]
TestAccDataplexDatascanIamPolicyGenerated [Debug log]
TestAccInstanceGroupManager_autoHealingPolicies [Debug log]
TestAccInstanceGroupManager_basic [Debug log]
TestAccInstanceGroupManager_resourceManagerTags [Debug log]
TestAccInstanceGroupManager_self_link_unique [Debug log]
TestAccInstanceGroupManager_stateful [Debug log]
TestAccInstanceGroupManager_stoppedSuspendedTargetSize [Debug log]
TestAccInstanceGroupManager_targetSizeZero [Debug log]
TestAccInstanceGroupManager_update [Debug log]
TestAccInstanceGroupManager_versions [Debug log]
TestAccInstanceGroupManager_waitForStatus [Debug log]
TestAccLoggingFolderSettings_update [Debug log]
TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Debug log]
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update [Debug log]
TestAccNetappStoragePool_storagePoolCreateExample [Debug log]
TestAccNetappStoragePool_storagePoolCreateExample_update [Debug log]
TestAccNotebooksInstanceIamPolicyGenerated [Debug log]
TestAccNotebooksInstance_create_vm_image [Debug log]
TestAccNotebooksInstance_notebookInstanceBasicExample [Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccComposerEnvironmentComposer2_private [Error message] [Debug log]
TestAccComposerEnvironmentComposer3_basic [Error message] [Debug log]
TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork [Error message] [Debug log]
TestAccComposerEnvironment_composerV2MasterAuthNetworks [Error message] [Debug log]
TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccNotebooksInstance_create_gpu [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions
Copy link

github-actions bot commented Jun 30, 2025

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@zli82016
Copy link
Member

zli82016 commented Jul 2, 2025

The checks still fail.

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

zli82016
zli82016 requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks still failed.

@BBBmau BBBmau closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zli82016 zli82016 zli82016 requested changes

Assignees

No one assigned

Labels

service/terraform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.