added cluster disruption budget.

[yliaog]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `disruption_budget` field to `google_container_cluster` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 747 insertions(+), 586 deletions(-))
google-beta provider: Diff ( 3 files changed, 784 insertions(+), 670 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccContainerCluster_withMaintenanceDisruptionBudget

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 121 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 121 insertions(+), 2 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccContainerCluster_withMaintenanceDisruptionBudget

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[hao-nan-li]

Looks like the build failed with the following errors:

Error: google/services/container/resource_container_cluster.go:5426:23: undefined: container.DisruptionBudget
Error: google/services/container/resource_container_cluster.go:5443:4: unknown field DisruptionBudget in struct literal of type "google.golang.org/api/container/v1".MaintenancePolicy
Error: google/services/container/resource_container_cluster.go:5460:4: unknown field DisruptionBudget in struct literal of type "google.golang.org/api/container/v1".MaintenancePolicy
Error: google/services/container/resource_container_cluster.go:6998:8: mp.DisruptionBudget undefined (type *"google.golang.org/api/container/v1".MaintenancePolicy has no field or method DisruptionBudget)
Error: google/services/container/resource_container_cluster.go:7000:44: mp.DisruptionBudget undefined (type *"google.golang.org/api/container/v1".MaintenancePolicy has no field or method DisruptionBudget)
Error: google/services/container/resource_container_cluster.go:7001:44: mp.DisruptionBudget undefined (type *"google.golang.org/api/container/v1".MaintenancePolicy has no field or method DisruptionBudget)

Could you try to fix them and test it locally?

[github-actions]

@yliaog, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[yliaog]

the API field DisruptionBudget will be made public, and rolled out in the next couple of weeks.

[github-actions]

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[yliaog]

/disable-review-reminders

[hao-nan-li]

Could you make this a draft PR and re-open it when it's ready?

[yliaog]

sure, converted to Draft for now. Thanks.