Ga security policy v2#16094
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
…ompute_security_policy This change promotes the request_body_inspection_size field from Beta to GA in the google_compute_security_policy resource. The GA Compute API (v1) now supports this field with values: 8KB, 16KB, 32KB, 48KB, and 64KB for WAF request body inspection configuration. Changes: - Removed version guards from schema definition - Removed version guards from expand/flatten functions - Updated ForceSendFields to include field for all versions - Removed [Beta] marker from documentation - Enabled tests for GA provider ```release-note:enhancement compute: promoted `request_body_inspection_size` to GA in `google_compute_security_policy` ```
4bf5ecb to
74aca0d
Compare
|
Hi @roaks3, a client has asked about support related to this PR. |
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
Hey @roaks3, could you take a look on that, please? |
roaks3
left a comment
There was a problem hiding this comment.
LGTM; running tests now, although they will likely be unchanged because we only run beta tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1325 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@roaks3 could you, please, run the check again? I forgot to change the meta.yaml file before. Probably will pass now and can be merged. Tks! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1325 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
@roaks3 tks for your attention Ryan! Could you give me an estimate of when the merger will take place? |
|
@roaks3 tks a lot! |
ea30169
Description
This PR promotes the
request_body_inspection_sizefield from Beta to GA in thegoogle_compute_security_policyresource.GA API Confirmation: The Compute v1 (GA) API already exposes
requestBodyInspectionSizeand supports values up to 64KB.Changes Made
1. Schema Definition
{{- if ne $.TargetVersionName "ga" }}) fromrequest_body_inspection_sizefield2. Expand/Flatten Functions
expandSecurityPolicyAdvancedOptionsConfigflattenSecurityPolicyAdvancedOptionsConfig3. ForceSendFields
advancedOptionsConfig.requestBodyInspectionSizefor all versions4. Documentation
[Beta]marker fromrequest_body_inspection_sizefield5. Tests
request_body_inspection_sizeTesting
The acceptance test
TestAccComputeSecurityPolicy_withAdvancedOptionsConfigincludes:request_body_inspection_size = "64KB"