Skip to content

feat(spanner): support user_project_override in spanner iam resources#16155

Open
timothyklee wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
timothyklee:tklee/spanner-iam-user-project-override
Open

feat(spanner): support user_project_override in spanner iam resources#16155
timothyklee wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
timothyklee:tklee/spanner-iam-user-project-override

Conversation

@timothyklee
Copy link

@timothyklee timothyklee commented Jan 16, 2026

spanner_database_iam and spanner_instance_iam resources currently do not support user_project_override. This will inject the required X-Goog-User-Project header for that feature to work.

spanner: support user_project_override in `spanner_database_iam` and `spanner_instance_iam` resources

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 16, 2026
@timothyklee timothyklee force-pushed the tklee/spanner-iam-user-project-override branch 2 times, most recently from d6bb7b0 to 9a1b8b7 Compare January 16, 2026 23:04
@timothyklee timothyklee marked this pull request as ready for review January 23, 2026 19:46
@github-actions github-actions bot requested a review from BBBmau January 23, 2026 19:47
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@timothyklee timothyklee force-pushed the tklee/spanner-iam-user-project-override branch from 9a1b8b7 to d89b1c8 Compare January 23, 2026 23:31
@modular-magician modular-magician added service/spanner and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 23, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 53 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 53 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 40 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 48
Passed tests: 42
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • spanner

🟢 All tests passed!

View the build log

@github-actions
Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants