Fix: google_service_networking_connection perma-diff on reserved_peering_ranges by SCSAndre · Pull Request #16191 · GoogleCloudPlatform/magic-modules

SCSAndre · 2026-01-22T21:57:20Z

Description

Fixes #20398

This PR resolves a perma-diff issue in google_service_networking_connection where the order of reserved_peering_ranges caused Terraform to detect changes during every plan, even if the set of ranges remained identical.

Changes

Schema Change: added a DiffSuppressFunc to reserved_peering_ranges in resource_service_networking_connection.go to ignore ordering differences between config and state.
Helper Function: added stringListDiffSuppress to handle the unordered comparison of the string list.
Test: Added TestAccServiceNetworkingConnection_reorder to resource_service_networking_connection_test.go to verify that changing the order of ranges does not trigger an update.

Breaking Change Note

This change utilizes DiffSuppressFunc on the existing TypeList schema rather than converting to TypeSet.

Impact: None. This is not a breaking change. Existing state files remain compatible as the schema type has not changed.

Verification

I have verified this locally by running the new acceptance test:
make testacc TEST=./google/services/servicenetworking TESTARGS='-run TestAccServiceNetworkingConnection_reorder'
Result: PASS

`google_service_networking_connection`: fixed a permanent diff issue where changing the order of `reserved_peering_ranges` triggered an unnecessary update.

…ompute_security_policy This change promotes the request_body_inspection_size field from Beta to GA in the google_compute_security_policy resource. The GA Compute API (v1) now supports this field with values: 8KB, 16KB, 32KB, 48KB, and 64KB for WAF request body inspection configuration. Changes: - Removed version guards from schema definition - Removed version guards from expand/flatten functions - Updated ForceSendFields to include field for all versions - Removed [Beta] marker from documentation - Enabled tests for GA provider ```release-note:enhancement compute: promoted `request_body_inspection_size` to GA in `google_compute_security_policy` ```

…ing_ranges

github-actions · 2026-01-22T21:58:26Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-01-23T22:49:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 97 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 97 insertions(+), 3 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field reserved_peering_ranges changed from TypeList to TypeSet on google_service_networking_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2026-01-23T22:55:28Z

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

servicenetworking

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceNetworkingConnection_reorder

Get to know how VCR tests work

modular-magician · 2026-01-23T23:01:55Z

🟢 Tests passed during RECORDING mode:
TestAccServiceNetworkingConnection_reorder [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

shuyama1

Thanks for the fix. It seems reasonable, but changing from list to set is a breaking change and needs to wait until the next major release

https://googlecloudplatform.github.io/magic-modules/breaking-changes/breaking-changes/#field-level-breaking-changes

https://googlecloudplatform.github.io/magic-modules/breaking-changes/make-a-breaking-change/#make-a-breaking-change

SCSAndre · 2026-01-26T15:44:58Z

Hey @shuyama1, I thought it would be a minor release, considering the documentation:

https://googlecloudplatform.github.io/magic-modules/breaking-changes/make-a-breaking-change/#make-a-breaking-change:

 [...] "Changing a List to a Set where the field is unordered and the order returned from the API changes unpredictably".

SCSAndre · 2026-01-26T15:52:15Z

But in the opposite direction the documentation (https://googlecloudplatform.github.io/magic-modules/breaking-changes/breaking-changes/#field-level-breaking-changes) states that the same modification can be an example of a breaking change.

"Field-level breaking changes:

. Removing or renaming a field
. Changing field output type
. Between primitive types, like changing a String to an Integer
. Between complex types like changing a List to a Set."

SCSAndre · 2026-01-26T18:43:45Z

@shuyama1 maybe I could try to solve it using a DiffSuppressFunc?

shuyama1

Thanks for looking into the docs!

My understanding is that the API preserves the order of the list as sent (evidenced by the fact mentioned in the GH issue that static lists work fine without diffs). Therefore, implementing this as a List is technically correct behavior.

Changing from List to Set is a breaking change because it breaks index-based interpolations. We can only make this change in a minor release if the API returns items in an unpredictable order (which would make index references unreliable anyway), but that seems not the case here.

- Updated resource_service_networking_connection.go - Modified resource_service_networking_connection_meta.yaml - Resolves connection reordering permadiff issue

…ecurity_policy_test.go.tmpl

…ecurity_policy_meta.yaml.tmpl

…ecurity_policy.go.tmpl

…icy.html.markdown

…-permadiff

modular-magician · 2026-01-29T16:36:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 128 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 128 insertions(+), 4 deletions(-))

modular-magician · 2026-01-29T16:42:25Z

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

servicenetworking

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceNetworkingConnection_reorder

Get to know how VCR tests work

modular-magician · 2026-01-29T16:48:01Z

🔴 Tests failed during RECORDING mode:
TestAccServiceNetworkingConnection_reorder [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

SCSAndre · 2026-01-29T17:51:13Z

Closing this PR to reopen with a clean branch that contains only the relevant commits.
New PR incoming with the same fix.
@shuyama1

SCSAndre · 2026-01-29T17:56:54Z

Closed in favor of clean PR: #16259

SCSAndre added 3 commits January 7, 2026 19:07

fix: necessary changes on the meta.yaml file

06ddf17

Fix: google_service_networking_connection perma-diff on reserved_peer…

0153735

…ing_ranges

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 22, 2026

github-actions bot requested a review from shuyama1 January 22, 2026 21:58

SCSAndre force-pushed the fix-servicenetworking-permadiff branch from 0153735 to 5277d17 Compare January 22, 2026 22:36

SCSAndre mentioned this pull request Jan 23, 2026

google_service_networking_connection always detects changes if reserved_peering_ranges has multiple entries and is not a static list hashicorp/terraform-provider-google#20398

Open

modular-magician added service/service-networking and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 23, 2026

shuyama1 reviewed Jan 23, 2026

View reviewed changes

github-actions bot requested a review from shuyama1 January 26, 2026 15:46

shuyama1 reviewed Jan 28, 2026

View reviewed changes

Fix service networking connection permadiff

486f2dd

- Updated resource_service_networking_connection.go - Modified resource_service_networking_connection_meta.yaml - Resolves connection reordering permadiff issue

SCSAndre force-pushed the fix-servicenetworking-permadiff branch from 5277d17 to 486f2dd Compare January 28, 2026 20:45

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2026

github-actions bot requested a review from shuyama1 January 28, 2026 20:46

SCSAndre and others added 6 commits January 28, 2026 18:07

Delete mmv1/third_party/terraform/services/compute/resource_compute_s…

5ea617b

…ecurity_policy_test.go.tmpl

Delete mmv1/third_party/terraform/services/compute/resource_compute_s…

f21dcee

…ecurity_policy_meta.yaml.tmpl

Delete mmv1/third_party/terraform/services/compute/resource_compute_s…

e2aad92

…ecurity_policy.go.tmpl

Delete mmv1/third_party/terraform/website/docs/r/compute_security_pol…

dce2170

…icy.html.markdown

Fix: Revert accidental files and update networking connection

dd07aa9

Merge remote-tracking branch 'origin/main' into fix-servicenetworking…

2f44810

…-permadiff

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2026

SCSAndre closed this Jan 29, 2026

SCSAndre mentioned this pull request Jan 29, 2026

Fix: google_service_networking_connection perma-diff on reserved_peering_ranges #16259

Open

Conversation

SCSAndre commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Breaking Change Note

Verification

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

modular-magician commented Jan 23, 2026

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Jan 23, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 23, 2026

Uh oh!

shuyama1 left a comment

Choose a reason for hiding this comment

Uh oh!

SCSAndre commented Jan 26, 2026

Uh oh!

SCSAndre commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SCSAndre commented Jan 26, 2026

Uh oh!

shuyama1 left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jan 29, 2026

Diff report

Uh oh!

modular-magician commented Jan 29, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2026

Uh oh!

SCSAndre commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SCSAndre commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SCSAndre commented Jan 22, 2026 •

edited

Loading

SCSAndre commented Jan 26, 2026 •

edited

Loading

SCSAndre commented Jan 29, 2026 •

edited

Loading

SCSAndre commented Jan 29, 2026 •

edited

Loading