Fix toggling default compute class in Autopilot

[norbertcyran]

Fixed toggling default compute class in Autopilot.

Fixes hashicorp/terraform-provider-google#24688

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: fixed an issue when toggling `default_compute_class_enabled` in `google_container_cluster` with Autopilot enabled

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 90 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 90 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 280
Passed tests: 250
Skipped tests: 15
Affected tests: 15

Click here to see the affected service packages

• container

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerClusterCustomServiceAccount_withAutopilot
• TestAccContainerCluster_autoprovisioningDefaultsManagement
• TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings
• TestAccContainerCluster_autoprovisioningLocations
• TestAccContainerCluster_nodeAutoprovisioning
• TestAccContainerCluster_nodeAutoprovisioningDefaults
• TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey
• TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb
• TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType
• TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType
• TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance
• TestAccContainerCluster_nodeAutoprovisioningNetworkTags
• TestAccContainerCluster_withAutopilotDefaultComputeClassEnabled
• TestAccContainerCluster_withAutoscalingProfile
• TestAccContainerCluster_withDefaultComputeClassEnabled

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autoprovisioningLocations [Debug log]
TestAccContainerCluster_nodeAutoprovisioning [Debug log]
TestAccContainerCluster_nodeAutoprovisioningNetworkTags [Debug log]
TestAccContainerCluster_withAutopilotDefaultComputeClassEnabled [Debug log]
TestAccContainerCluster_withAutoscalingProfile [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerClusterCustomServiceAccount_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsManagement [Error message] [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings [Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults [Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey [Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb [Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType [Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType [Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance [Error message] [Debug log]
TestAccContainerCluster_withDefaultComputeClassEnabled [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 86 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 86 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 280
Passed tests: 254
Skipped tests: 15
Affected tests: 11

Click here to see the affected service packages

• container

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_autoprovisioningDefaultsManagement
• TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings
• TestAccContainerCluster_autoprovisioningLocations
• TestAccContainerCluster_nodeAutoprovisioning
• TestAccContainerCluster_nodeAutoprovisioningDefaults
• TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb
• TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType
• TestAccContainerCluster_nodeAutoprovisioningNetworkTags
• TestAccContainerCluster_withAutopilotDefaultComputeClassEnabled
• TestAccContainerCluster_withAutoscalingProfile
• TestAccContainerCluster_withDefaultComputeClassEnabled

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autoprovisioningDefaultsManagement [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings [Debug log]
TestAccContainerCluster_autoprovisioningLocations [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType [Debug log]
TestAccContainerCluster_nodeAutoprovisioningNetworkTags [Debug log]
TestAccContainerCluster_withAutopilotDefaultComputeClassEnabled [Debug log]
TestAccContainerCluster_withAutoscalingProfile [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_nodeAutoprovisioning [Error message] [Debug log]
TestAccContainerCluster_withDefaultComputeClassEnabled [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[slevenick]

There are a couple related test failures. Were you able to run the tests?

[norbertcyran]

There are a couple related test failures. Were you able to run the tests?

@slevenick Yes, TestAccContainerCluster_nodeAutoprovisioning turned out to be flaky. There was a race condition in which NAP creates a node pool in between cluster create/update and ImportStateVerify steps. I added "node_pool" to ImportStateVerifyIgnore in that test and couple of other tests related to autoprovisioning.

TestAccContainerCluster_withDefaultComputeClassEnabled - there was a small regression that slipped through between one test run and another, it should be fixed now

Thanks for the review!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 125 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 2 files changed, 125 insertions(+), 33 deletions(-))

[modular-magician]

Tests analytics

Total tests: 280
Passed tests: 263
Skipped tests: 15
Affected tests: 2

Click here to see the affected service packages

• container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_nodeAutoprovisioning
• TestAccContainerCluster_withDefaultComputeClassEnabled

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_nodeAutoprovisioning [Debug log]
TestAccContainerCluster_withDefaultComputeClassEnabled [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[slevenick]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 125 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 2 files changed, 125 insertions(+), 33 deletions(-))

[modular-magician]

Tests analytics

Total tests: 280
Passed tests: 265
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages

• container

🟢 All tests passed!

View the build log