Skip to content

Modify the redis cluster update tests#16218

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:redis-test
Jan 26, 2026
Merged

Modify the redis cluster update tests#16218
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:redis-test

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Jan 24, 2026

TestAccRedisCluster_redisClusterMaintenanceVersion and TestAccRedisCluster_redisClusterHaWithLabelsUpdate were no-op tests. Modify those tests to update tests.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 13 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 36
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • redis

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterHaWithLabelsUpdate
  • TestAccRedisCluster_redisClusterMaintenanceVersion

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_redisClusterHaWithLabelsUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterMaintenanceVersion [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 13 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccRedisCluster_redisClusterMaintenanceVersion

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_redisClusterMaintenanceVersion [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 marked this pull request as ready for review January 26, 2026 17:30
@zli82016
Copy link
Member Author

@modular-magician reassign-reviewer

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson January 26, 2026 17:46
@zli82016 zli82016 added this pull request to the merge queue Jan 26, 2026
Merged via the queue into GoogleCloudPlatform:main with commit d4c08d6 Jan 26, 2026
27 checks passed
@zli82016 zli82016 deleted the redis-test branch January 26, 2026 18:10
zli82016 added a commit to zli82016/magic-modules that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants