Add Cloud Identity Policy resource (v1beta1) to terraform google-beta #16241

gomu18 · 2026-01-27T20:08:29Z

Adding support for the resource https://docs.cloud.google.com/identity/docs/reference/rest/v1beta1/policies in Terraform beta

`google_cloud_identity_policy`

override-missing-service-label

github-actions · 2026-01-27T20:09:31Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-01-27T20:19:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 233 insertions(+))
google-beta provider: Diff ( 6 files changed, 1131 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_policy" "primary" {
  customer = # value needed
  policy_query {
    group    = # value needed
    org_unit = # value needed
    query    = # value needed
  }
  setting {
    type       = # value needed
    value_json = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-01-27T20:29:28Z

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

hao-nan-li

Could you add some test for this new resource?

modular-magician · 2026-01-28T13:29:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 378 insertions(+))
google-beta provider: Diff ( 8 files changed, 1411 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_policy" "primary" {
  customer = # value needed
  policy_query {
    group    = # value needed
    org_unit = # value needed
    query    = # value needed
  }
  setting {
    type       = # value needed
    value_json = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-01-28T13:39:42Z

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-28T13:40:01Z

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityPolicy_cloudidentityPolicyBasic [Error message] [Debug log]
TestAccCloudIdentityPolicy_cloudidentityPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-29T06:34:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 378 insertions(+))
google-beta provider: Diff ( 8 files changed, 1411 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-01-29T06:44:31Z

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-29T06:44:50Z

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityPolicy_cloudidentityPolicyBasic [Error message] [Debug log]
TestAccCloudIdentityPolicy_cloudidentityPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-29T14:26:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 378 insertions(+))
google-beta provider: Diff ( 8 files changed, 1411 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 257 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-01-29T14:36:15Z

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-29T14:36:33Z

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityPolicy_cloudidentityPolicyBasic [Error message] [Debug log]
TestAccCloudIdentityPolicy_cloudidentityPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-02-02T09:57:57Z

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2026-02-02T18:08:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1049 insertions(+))
google-beta provider: Diff ( 9 files changed, 2022 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 286 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_policy" "primary" {
  policy_query {
    group = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-02-02T18:17:28Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-02-02T18:17:51Z

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityPolicy_cloudidentityPolicyBasic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

gomu18 · 2026-02-02T18:27:04Z

I have added resource acceptance tests to test out Create/Update/Delete/Get flows. I ran into 2 issues here.

I was unable to run the test in RECORDING mode in CI because the API requires Workspace Super Admin credentials which cannot be replicated in a CI setup. So I recorded the tests locally, and the committed those files in test-fixtures directory so that they get copied over and can be REPLAYED, but the PR still shows failures for running in RECORDING mode. How to stop that?
I want to generate this change only for google-beta and have mentioned this in the resource yaml as well, but I still have build and unit tests failing for the google provider. Can you help me with how to disable that?

The large PR is because of the checked in VCR cassette file, and if that is excluded, it is less than the limit of 500 lines of code. Thanks.

hao-nan-li · 2026-02-02T18:41:14Z

You can skip the test on CI, and upload logs from a local run.
Search for existing code with "{{ if eq $.TargetVersionName ga }}", these blocks are used to exclude changes to google-provider.

modular-magician · 2026-02-02T19:07:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 879 insertions(+))
google-beta provider: Diff ( 9 files changed, 2022 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 286 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_policy" "primary" {
  policy_query {
    group = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-02-02T19:16:30Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-02-02T19:16:50Z

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityPolicy_cloudidentityPolicyBasic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-02-02T19:41:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 879 insertions(+))
google-beta provider: Diff ( 9 files changed, 2024 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 286 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_policy" "primary" {
  policy_query {
    group = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-02-02T19:50:34Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccCloudIdentityPolicy_cloudidentityPolicyBasic

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-02-03T05:19:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 879 insertions(+))
google-beta provider: Diff ( 9 files changed, 2024 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 286 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_policy" "primary" {
  policy_query {
    group = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_cloud_identity_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-02-03T05:29:34Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccCloudIdentityPolicy_cloudidentityPolicyBasic

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

Add Cloud Identity Policy resource (v1beta1) to terraform google-beta

66cde50

github-actions bot requested a review from hao-nan-li January 27, 2026 20:09

hao-nan-li reviewed Jan 27, 2026

View reviewed changes

Add tests for Cloud Identity Policy resource

bc3724c

github-actions bot requested a review from hao-nan-li January 28, 2026 13:17

Remove random suffix from constant fields and fix formatting errors

4b9c872

Remove random suffix from all update tests

4474860

Run test locally and check in recorded casettes

a6fdc39

Exclude the test from ga provider

cfd2c75

Skip tests until service accounts can call Public Policy API

9001b35

gomu18 marked this pull request as draft February 3, 2026 05:01

gomu18 marked this pull request as ready for review February 3, 2026 05:02

gomu18 closed this Feb 3, 2026

gomu18 reopened this Feb 3, 2026

Add Cloud Identity Policy resource (v1beta1) to terraform google-beta #16241

Are you sure you want to change the base?

Add Cloud Identity Policy resource (v1beta1) to terraform google-beta #16241

Uh oh!

Conversation

gomu18 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

modular-magician commented Jan 27, 2026

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Jan 27, 2026

Tests analytics

Uh oh!

hao-nan-li left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jan 28, 2026

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Jan 28, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 28, 2026

Uh oh!

modular-magician commented Jan 29, 2026

Diff report

Missing service labels

Uh oh!

modular-magician commented Jan 29, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2026

Uh oh!

modular-magician commented Jan 29, 2026

Diff report

Missing service labels

Uh oh!

modular-magician commented Jan 29, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2026

Uh oh!

github-actions bot commented Feb 2, 2026

Uh oh!

modular-magician commented Feb 2, 2026

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Feb 2, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 2, 2026

Uh oh!

gomu18 commented Feb 2, 2026

Uh oh!

hao-nan-li commented Feb 2, 2026

Uh oh!

modular-magician commented Feb 2, 2026

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Feb 2, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 2, 2026

Uh oh!

gomu18 commented Jan 27, 2026 •

edited

Loading