Skip to content

Conversation

@rambleraptor
Copy link
Contributor

@rambleraptor rambleraptor commented Feb 2, 2026

Bit of a weird situation:

The BigLake Iceberg Namespace resource follows the Iceberg REST Catalog specification. That means that it isn't a Google compliant API at all! IAM still follows the traditional Google API structure. With that in mind, I've gone ahead and built out the resources in the most Magic Modules way I could.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

biglake_iceberg_namespace

@rambleraptor rambleraptor marked this pull request as draft February 2, 2026 23:57
@github-actions github-actions bot requested a review from NickElliot February 2, 2026 23:57
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1319 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1319 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 375 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_biglake_iceberg_namespace
    • Expected Document Path: /website/docs/r/biglake_iceberg_namespace.html.markdown
    • Fields: [catalog namespace namespace_id project properties]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 5
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • biglakeiceberg

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated [Debug log]
TestAccBiglakeIcebergIcebergNamespace_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1851 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1851 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 567 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_basic
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • biglakeiceberg

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1884 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1884 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 551 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • biglakeiceberg

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1871 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1871 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 517 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_namespace_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
  catalog      = # value needed
  members      = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_member" "primary" {
  catalog      = # value needed
  member       = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
  catalog      = # value needed
  namespace_id = # value needed
  policy_data  = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1871 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1871 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 517 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_namespace_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
  catalog      = # value needed
  members      = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_member" "primary" {
  catalog      = # value needed
  member       = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
  catalog      = # value needed
  namespace_id = # value needed
  policy_data  = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 5
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • biglakeiceberg

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 5
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • biglakeiceberg

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1864 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 1864 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 517 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_namespace_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
  catalog      = # value needed
  members      = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_member" "primary" {
  catalog      = # value needed
  member       = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
  catalog      = # value needed
  namespace_id = # value needed
  policy_data  = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 6
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • biglakeiceberg

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated [Error message] [Debug log]
TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1869 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 11 files changed, 1869 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 517 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_namespace_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
  catalog      = # value needed
  members      = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_member" "primary" {
  catalog      = # value needed
  member       = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
  catalog      = # value needed
  namespace_id = # value needed
  policy_data  = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1869 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 11 files changed, 1869 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 517 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_namespace_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
  catalog      = # value needed
  members      = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_member" "primary" {
  catalog      = # value needed
  member       = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
  catalog      = # value needed
  namespace_id = # value needed
  policy_data  = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 1867 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 12 files changed, 1867 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 517 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_namespace_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
  catalog      = # value needed
  members      = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_member" "primary" {
  catalog      = # value needed
  member       = # value needed
  namespace_id = # value needed
  role         = # value needed
}

Resource: google_biglake_iceberg_namespace_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
  catalog      = # value needed
  namespace_id = # value needed
  policy_data  = # value needed
}

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample

Tests analytics

Total tests: 5983
Passed tests: 5348
Skipped tests: 633
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceUpdateExample

Tests analytics

Total tests: 5982
Passed tests: 5347
Skipped tests: 633
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_policy_scoped [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rambleraptor rambleraptor marked this pull request as ready for review February 3, 2026 21:21
@rambleraptor
Copy link
Contributor Author

@melinath was the reviewer on an attempt to build just the IAM resources (long story, feel free to look at #16175)

@melinath
Copy link
Member

melinath commented Feb 3, 2026

Taking this on as reviewer of the original PR.

@modular-magician reassign-reviewer @melinath

@github-actions github-actions bot requested review from melinath and removed request for NickElliot February 3, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants