-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Biglake namespace resource #16280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Biglake namespace resource #16280
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
catalog = # value needed
members = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_member" "primary" {
catalog = # value needed
member = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
catalog = # value needed
namespace_id = # value needed
policy_data = # value needed
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
catalog = # value needed
members = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_member" "primary" {
catalog = # value needed
member = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
catalog = # value needed
namespace_id = # value needed
policy_data = # value needed
}
|
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
catalog = # value needed
members = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_member" "primary" {
catalog = # value needed
member = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
catalog = # value needed
namespace_id = # value needed
policy_data = # value needed
}
|
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
catalog = # value needed
members = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_member" "primary" {
catalog = # value needed
member = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
catalog = # value needed
namespace_id = # value needed
policy_data = # value needed
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
catalog = # value needed
members = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_member" "primary" {
catalog = # value needed
member = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
catalog = # value needed
namespace_id = # value needed
policy_data = # value needed
}
|
a9caf4d to
066735d
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_biglake_iceberg_namespace_iam_binding" "primary" {
catalog = # value needed
members = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_member" "primary" {
catalog = # value needed
member = # value needed
namespace_id = # value needed
role = # value needed
}
Resource: resource "google_biglake_iceberg_namespace_iam_policy" "primary" {
catalog = # value needed
namespace_id = # value needed
policy_data = # value needed
}
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 5983 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 5982 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Taking this on as reviewer of the original PR. @modular-magician reassign-reviewer @melinath |
Bit of a weird situation:
The BigLake Iceberg Namespace resource follows the Iceberg REST Catalog specification. That means that it isn't a Google compliant API at all! IAM still follows the traditional Google API structure. With that in mind, I've gone ahead and built out the resources in the most Magic Modules way I could.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.