Skip to content

Conversation

@zjalicf
Copy link

@zjalicf zjalicf commented Feb 3, 2026

Adds support for the enhancedQueryInsightsEnabled API field in google_sql_database_instance.settings.insights_config.

This field enables the Query Insights Enhanced feature for Enterprise Plus instances. Currently, it is not possible to change this field via terraform, but it is available in REST API doc:

Fixes: hashicorp/terraform-provider-google#22281

sql: added `enhanced_query_insights_enabled` field to `google_sql_database_instance` resource `insights_config` block

@google-cla
Copy link

google-cla bot commented Feb 3, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@zjalicf
Copy link
Author

zjalicf commented Feb 3, 2026

Looks like github worklow uses old go client. This was added only 3 weeks ago:

https://github.com/googleapis/google-api-go-client/blame/29bd84381608db3db0385bd8f4544af458df7329/sqladmin/v1beta4/sqladmin-gen.go#L3068

not sure what is the best way forward here, other than updating CI/CD

@SirGitsalot
Copy link
Member

FYI #16270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_sql_database_instance - Add missing configuration for insights_config

3 participants