Skip to content

Conversation

@duvni
Copy link
Contributor

@duvni duvni commented Feb 3, 2026

Promoting the Network Security Mirroring Broker resources and properties to GA, which includes changes to:

  • google_network_security_mirroring_endpoint
  • google_network_security_mirroring_endpoint_group

APIs have already been promoted to v1.

networksecurity: promoted `google_network_security_mirroring_endpoint`, `google_network_security_mirroring_endpoint_group` resources and properties from Beta to GA

@github-actions github-actions bot requested a review from SirGitsalot February 3, 2026 11:12
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1249 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 5 files changed, 6 insertions(+), 30 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 250 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field type added as optional with a default value and force new on pre-existing resource google_network_security_mirroring_endpoint_group. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBrokerBasicExample
  • TestAccNetworkSecurityMirroringEndpoint_networkSecurityMirroringEndpointBasicExample
  • TestAccNetworkSecurityMirroringEndpoint_update

Tests analytics

Total tests: 78
Passed tests: 73
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

🟢 All tests passed!

View the build log

@duvni
Copy link
Contributor Author

duvni commented Feb 3, 2026

@SirGitsalot, the terraform-provider-breaking-change-test failed here, I believe the failure is the same one I had when I first introduced the type field in my previous PR, and we're seeing it again here because the field is promoted from beta to GA.

For full context see my previous comment on the PR that introduced the field: #15212 (comment)

The same reasoning applies here as well, and this change is completely safe so override-breaking-change label can be safely added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants