Skip to content

Conversation

@linyihai
Copy link
Contributor

@linyihai linyihai commented Jan 28, 2026

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Closed #6287

What's changed and what's your intention?

Same as #6995 but for JSON Format.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@linyihai linyihai requested a review from a team as a code owner January 28, 2026 10:03
@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Jan 28, 2026
@linyihai linyihai changed the title feat(copy_to_json): add date_format/timestamp_format/`time_format… feat(copy_to_json): add date_format/timestamp_format/time_format for JSON format copy Jan 28, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @linyihai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new formatting options for JSON output, specifically for date, time, and timestamp fields. These changes enhance the flexibility of the COPY TO command when exporting data in JSON format, allowing users to specify their desired output formats. The implementation includes modifications to the JsonFormat struct and the stream_to_json function, along with updates to existing tests to validate the new functionality.

Highlights

  • New Features: Adds date_format, timestamp_format, and time_format options for JSON format when copying data, mirroring the functionality already present for CSV format.
  • Code Changes: Modifies JsonFormat struct to include optional fields for timestamp_format, time_format, and date_format. Updates stream_to_json function to utilize these formats when writing JSON data.
  • Testing: Updates tests to include time formatting options, ensuring the new functionality works as expected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for date_format, timestamp_format, and time_format options for JSON format exports, aligning it with the functionality already present for CSV. The implementation is sound, introducing the new format options to JsonFormat and using them to configure arrow::json::WriterBuilder. The accompanying test changes are good, but there's an opportunity to improve integration test coverage. I've provided a couple of suggestions to enhance code conciseness and test completeness.


COPY (select host, cpu, jsons, ts, ts2 from demo where host = 'host2') TO '${SQLNESS_HOME}/export/demo.csv' WITH (format='csv', timestamp_format='%m-%d-%Y', date_format='%Y/%m/%d');

COPY (select host, cpu, jsons, ts, ts2 from demo where host = 'host2') TO '${SQLNESS_HOME}/export/demo.json' WITH (format='json', timestamp_format='%m-%d-%Y', date_format='%Y/%m/%d');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new time_format option for JSON export is not covered in this integration test. Please consider adding a column with a TIME data type to the demo table and a test case that uses time_format to ensure the feature is fully tested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Yihai Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add date and timestamp format to COPY TO (CSV, JSON)

1 participant