Add span string support for diagnostics test cases #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow specifying expected diagnostic spans using exact text strings instead of byte offsets. This makes tests more readable and maintainable. Changes: - Add `span` field to DiagnosticItem (optional string) - When `span` is specified, resolve it to byte offsets by searching the editor content for an exact match - Error if span string not found or found multiple times (ambiguous) - Existing start/end fields still work for edge cases where span string would be ambiguous - Update 3 test cases to use the new span syntax
Test cases: - Found once (normal case) - At start of content - At end of content - Not found (error) - Ambiguous (multiple matches, error) - With quotes (real-world case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying expected diagnostic spans using exact text strings
instead of byte offsets. This makes tests more readable and maintainable.
Changes:
spanfield to DiagnosticItem (optional string)spanis specified, resolve it to byte offsets by searchingthe editor content for an exact match
string would be ambiguous