Remove pub from inner fields of Map, NodeArray, and NodeTuple #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This encapsulates the internal data structures by making inner fields private and exposing public methods for access. Changes include: - Remove pub from Map<K, V> inner IndexMap field - Remove pub from NodeArray inner Vec<NodeId> field - Remove pub from NodeTuple inner Vec<NodeId> field - Add from_vec() methods to NodeArray and NodeTuple for construction - Add #[plural(...)] attributes to generate len, is_empty, iter methods - Update all usages to use public methods instead of direct field access Resolves TODO comments in map.rs and node.rs about removing pub fields.
ryo33
force-pushed
the
claude/implement-todo-item-DDejR
branch
from
54361c7 to
1f79ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encapsulates the internal data structures by making inner fields
private and exposing public methods for access. Changes include:
Resolves TODO comments in map.rs and node.rs about removing pub fields.