Skip to content

Conversation

@Xaver-DaRed
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Creates a mixin for flying wyrms flight logic, so we dont have the same logic repeated and coded diferently across the codebase

Steps to test these changes

Fight flying lizards

@Xaver-DaRed Xaver-DaRed force-pushed the flying-wyrms branch 3 times, most recently from 9716a0e to a84e71e Compare May 28, 2025 11:22
@Xaver-DaRed Xaver-DaRed marked this pull request as ready for review May 28, 2025 11:23
@TracentEden2
Copy link
Contributor

Could this apply to Ouryu in Monarch Linn for The Savage as well?

@Xaver-DaRed
Copy link
Contributor Author

Xaver-DaRed commented May 29, 2025

Could this apply to Ouryu in Monarch Linn for The Savage as well?

It already does, I thought. The idea is for this to be applicable to all wyrms that fly. Which admitedly arent that many more than this ones.

imagen

This ouryu can be forced down with the mistmelt item, unlike the Ouryu in The Savage II

@TracentEden2
Copy link
Contributor

Could this apply to Ouryu in Monarch Linn for The Savage as well?

It already does, I thought. The idea is for this to be applicable to all wyrms that fly. Which admitedly arent that many more than this ones.

imagen

This ouryu can be forced down with the mistmelt item, unlike the Ouryu in The Savage II

Ah, maybe I am missing something but I only see changes in the PR to the Ouryu mob file for Ouryu Cometh and not to the Ouryu mob file for The Savage.

@Xaver-DaRed Xaver-DaRed force-pushed the flying-wyrms branch 5 times, most recently from 790028b to 123d3d8 Compare June 10, 2025 13:51
Copy link
Contributor

@TracentEden2 TracentEden2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TracentEden2
Copy link
Contributor

Actually, I do have two small comments. Would the logic changes mean that mobs like Tiamat could use Mighty Strikes while in the air? Also should we be calling handlePhaseVariables on roam ticks as well, since some damage can take place even before engage, like a first damage spell?

@Xaver-DaRed
Copy link
Contributor Author

I added a check just now to disable 2-houring while in mid-air.
2-hours already disabled changing phase after all
imagen

@github-actions github-actions bot added the stale label Sep 18, 2025
@LandSandBoat LandSandBoat deleted a comment from github-actions bot Sep 18, 2025
@Xaver-DaRed Xaver-DaRed added the hold On hold, pending further action/info label Sep 18, 2025
@Xaver-DaRed
Copy link
Contributor Author

I will get to this in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants