Skip to content

Conversation

@WinterSolstice8
Copy link
Contributor

@WinterSolstice8 WinterSolstice8 commented Oct 11, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Basically, spawn the mob around the spawn position with some randomness. This is a big WIP so I currently have all spawned mobs from QMs fixed (probably going to stay that way), field mobs have a 10 yalm radius, dungeon mobs have a 5 yalm radius. At some point i'll be adding mobmods before undrafting

This is mostly to poll for features/feasibility. Default disabled of course

Known missing features:
instanced BCNM style-fights don't have fixed spawn positions yet
I'm probably forgetting some mobs that spawn in fixed positions
Some mobs that are set to be fixed (Groundskeepers) don't ALL have fixed positions.

Growing pains:
some spawn positions will probably be up against walls and the mobs will spawn along them more often than they should, or maybe even places they shouldn't be at all. There's probably going to have to be a lot of spots moved away from walls or "bad" spots to facilitate this

Steps to test these changes

Try spawning a mob that has one spawn position (and hasnt been spawned from a QM)
2025-10-10 18-13-24.webm

@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch 2 times, most recently from b6833ab to ef26123 Compare October 11, 2025 12:57
@MowFord
Copy link
Contributor

MowFord commented Oct 11, 2025

Cool idea, is fixed spawn not going to correlate heavily with mobmod no_move and the random range of spawn correlate with roam_distance?

Edit: to your second point you may want to try some arbitrary max number of times to find a valid randomized spawn position using losmesh to check if the point can "see" the base spawn position

@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch from ef26123 to 8aa0b35 Compare October 12, 2025 00:49
@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch 3 times, most recently from 9b3d10e to 12703d6 Compare October 13, 2025 01:12
@github-actions github-actions bot added the stale label Oct 27, 2025
@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch from ffd90e3 to 4c7ac7c Compare October 27, 2025 02:20
@github-actions github-actions bot removed the stale label Oct 30, 2025
@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch from 4c7ac7c to 37d3ef5 Compare October 30, 2025 14:44
@WinterSolstice8
Copy link
Contributor Author

Testing new PR blocking labels here

@WinterSolstice8 WinterSolstice8 added audit Confirmation / Citation Needed™ invalid This doesn't seem right (repro steps don't work, it's not actually a bug, etc.) and removed audit Confirmation / Citation Needed™ labels Oct 30, 2025
@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch from 37d3ef5 to ce92f54 Compare October 30, 2025 14:48
@WinterSolstice8 WinterSolstice8 removed the invalid This doesn't seem right (repro steps don't work, it's not actually a bug, etc.) label Oct 30, 2025
@github-actions github-actions bot added the stale label Nov 14, 2025
@WinterSolstice8 WinterSolstice8 force-pushed the mob_randomize_spawn_positions branch from ce92f54 to 47a6834 Compare November 14, 2025 02:22
@LandSandBoat LandSandBoat deleted a comment from github-actions bot Nov 14, 2025
@LandSandBoat LandSandBoat deleted a comment from github-actions bot Nov 14, 2025
@github-actions github-actions bot removed the stale label Nov 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

@github-actions github-actions bot added the stale label Dec 1, 2025
@WinterSolstice8 WinterSolstice8 added the hold On hold, pending further action/info label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants