Skip to content

Conversation

@vlouis
Copy link

@vlouis vlouis commented Jan 15, 2026

Save last folder path when using local image file.

Save last folder path when using local image file.
@chewitt
Copy link
Member

chewitt commented Jan 15, 2026

Please explain what the advantage of this change is, why it's necessary, etc. and show screenshots with the change. You also need to revise the commit message (and perhaps PR subject) to reflect what the change is. Thanks.

@vlouis
Copy link
Author

vlouis commented Jan 15, 2026

Sorry Chewitt, I'm not a "pro" github user.
If used local downloaded nightly images (and not in the default "download" folder), the program always ("Select file" button) jumps to default folder. With these 3 rows, if a local file selected, the path is saved to "LibreELEC.USB-SD.Creator.ini" file.
Isn't a big advantage, you are free reject it if you want.

@chewitt
Copy link
Member

chewitt commented Jan 15, 2026

I'm not a pro either, which is why I like to understand what might be merged :)

You need to run git commit --amend to change the current commit message from "Update Creator.cpp" to something like "Add support for a persistent local 'Select File' path" .. then git push -f origin master to push the local commit to your GitHub account; which will update this PR.

@chewitt chewitt changed the title Update creator.cpp Add support for a persistent local 'Select File' path Jan 15, 2026
@kambala-decapitator
Copy link
Collaborator

Your change only saves directory but never reads it. Am I missing something?

@vlouis
Copy link
Author

vlouis commented Jan 16, 2026

The value is used, look for "settings.value("preferred/savedir", getDefaultSaveDir())" at "creator.cpp" file.
I added to be saved at the manual file selection too ("Select file" button). It's useful for people like me, who use only previously downloaded nightly test images (and not to the default download folder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants