Generate a session as guest and send the action to view sign page #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor Mattos <[email protected]>
4 tasks
Member
Author
|
I didn't incremented the attempt when is an access with success. I used session and worked fine. |
When all data of signer is valid, is necessary to renew the duration of window time to do not return an expired session error Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feature/create-session-after-validate-link-from-email
branch
from
13dc37e to
72070e2
Compare
Signed-off-by: Vitor Mattos <[email protected]>
- Make the condition as gt and not gte. - Implement logs as debug level Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feature/create-session-after-validate-link-from-email
branch
from
39b58a3 to
dd799a0
Compare
giovannism20
suggested changes
Dec 29, 2023
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
Considering that now only have questions at this code review, I will mark as resolved and if we have any pending point, we can open a follow up issue to fix the pending points. We will need this PR here: #2037 |
delete-merged-branch
bot
deleted the
feature/create-session-after-validate-link-from-email
branch
Member
Author
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background scenario:
To-do
- [ ] Renew the date of last attempt and increment the attempts counter- [ ] Make possible sign the document