Skip to content

Conversation

@vitormattos
Copy link
Member

I made a grep to find by this method. Is an unused method

@vitormattos vitormattos self-assigned this Dec 29, 2023
@vitormattos vitormattos added this to the Next Major (29) milestone Dec 29, 2023
@vitormattos vitormattos force-pushed the feature/remove-unused-method branch 2 times, most recently from e31a5f1 to 45aaf7e Compare December 29, 2023 16:06
I made a grep to find. Is unused methods

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feature/remove-unused-method branch from 45aaf7e to f3464c9 Compare December 29, 2023 16:14
@giovannism20
Copy link
Member

Can u explain more about this grep ?

@vitormattos
Copy link
Member Author

Not exactly a grep but I made a search at my IDE and didn't found any reference to these methods.

getInfoOfFileToSignUsingSignRequestUuid
getInfoOfFileToSignUsingFileUuid

@vitormattos vitormattos marked this pull request as ready for review December 29, 2023 16:27
@giovannism20
Copy link
Member

So maybe would be more interesting if we make some manual tests just to guarantee it

@vitormattos
Copy link
Member Author

The previous context:
Before to implement the identify methods logic, all the logic to validate the signer was made by these methods.
Part of logic was moved to identify methods classes, in particular the logic that throw exceptions and validate if the file was signed.
The other part, that return data, was moved to other points of code because, as is possible to see at removed unit test, was very hard to maintain the methods. Was methods with a lot of responsibility and I followed removing the dependency of them. Now, when I started to look the code to make a task, I identified that haven't any place using them.

@vitormattos vitormattos merged commit f81a9fe into main Dec 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/remove-unused-method branch December 29, 2023 17:13
@vitormattos
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants