Feature/cleanup 2d places #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmluk
approved these changes
Jan 21, 2026
Contributor
Schmluk
left a comment
Schmluk
left a comment
There was a problem hiding this comment.
LGTM! Seems much cleaner. Small note: I think this breaks backwards compatibility for loading 2D places, would it make sense to a warning message to the IO if the attrs get loaded that they will be skipped or so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes old unused 2D place attributes inherited from the 3D places and renames some of the fields to drop the
pclprefix. Other change is that I swapped the mesh connections to be a list instead of a vector for in-place removals (which happen a lot). There's some corresponding changes to Hydra that I'm hoping to PR later today