Collect additional mixed_language_library output files #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thiago Cruz <thiago@squareup.com>
thiagohmcruz
force-pushed
the
thiago/collect-additional-mixed-lib-output-files
branch
from
c56229f to
bf9ecc5
Compare
thiagohmcruz
commented
Jan 9, 2026
luispadron
approved these changes
Jan 9, 2026
adincebic
approved these changes
Jan 9, 2026
Contributor
Author
|
Waiting for updates on the CI issue, should be able to land this Mon! |
Contributor
Closing/opening the PR triggered the jobs |
Contributor
Author
|
Taking a look at the failures |
Contributor
|
The |
Signed-off-by: Thiago Cruz <thiago@squareup.com>
thiagohmcruz
force-pushed
the
thiago/collect-additional-mixed-lib-output-files
branch
from
e4732c3 to
b83aaab
Compare
Contributor
Author
@brentleyjones yeah I TIL-ed about these failures this AM, found issues reported in Bazel for the two failures we're hitting here indeed, thx for flagging! Just pushed a fix for the linter |
brentleyjones
approved these changes
Jan 12, 2026
brentleyjones
deleted the
thiago/collect-additional-mixed-lib-output-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3258.
In
xcodeproj/internal/files/output_files.bzlusing_collect_output_filesas a reference starts collecting more outputs in_collect_mixed_language_output_filesto address the issue.I'll use #3259 to verify this fix is good (I will either rebase or cherry pick it here)