Split out updates to model config into its own function and call it during setup#12663
Merged
ananthsub merged 16 commits intoNVIDIA-NeMo:mlm-pretrain-loopfrom Mar 19, 2025
Merged
Conversation
maanug-nv
reviewed
Mar 18, 2025
maanug-nv
reviewed
Mar 18, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
setup-cleanup
branch
from
295f0cf to
e43d250
Compare
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
commented
Mar 18, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
merged commit 752edac
into
NVIDIA-NeMo:mlm-pretrain-loop
7 of 8 checks passed
hemildesai
pushed a commit
that referenced
this pull request
Mar 20, 2025
…uring setup (#12663) * move ddp config updates to setup Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * split into own function Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * names Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * add copyright for example Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * address comments Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * remove changes to get_model_from_config Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * update model config sync funcs as part of get_model_from_config Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * move back to setup, include grad scale func from optimizer Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lint Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * undo Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * right check Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * keep order Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * keep comment Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * remove arg Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * updates Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
hemildesai
pushed a commit
that referenced
this pull request
Apr 15, 2025
…uring setup (#12663) * move ddp config updates to setup Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * split into own function Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * names Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * add copyright for example Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * address comments Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * remove changes to get_model_from_config Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * update model config sync funcs as part of get_model_from_config Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * move back to setup, include grad scale func from optimizer Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lint Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * undo Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * right check Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * keep order Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * keep comment Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * remove arg Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * updates Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
jiemingz
pushed a commit
that referenced
this pull request
Jul 10, 2025
…uring setup (#12663) * move ddp config updates to setup Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * split into own function Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * names Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * add copyright for example Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * address comments Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * remove changes to get_model_from_config Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * update model config sync funcs as part of get_model_from_config Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * move back to setup, include grad scale func from optimizer Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lint Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * undo Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * right check Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * keep order Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * keep comment Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * remove arg Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * updates Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information