Removes use of torchaudio and moves transforms inside of NeMo#15211
Removes use of torchaudio and moves transforms inside of NeMo#15211blisc merged 17 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: blisc <blisc@users.noreply.github.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: blisc <blisc@users.noreply.github.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: blisc <blisc@users.noreply.github.com>
Signed-off-by: Jason <jasoli@nvidia.com>
nithinraok
left a comment
There was a problem hiding this comment.
LGTM.
@chtruong814 / @ko3n1g review for docker related changes.
…-NeMo#15211) * remove use of torchaudio.transforms; SQUIM todo Signed-off-by: Jason <jasoli@nvidia.com> * Apply isort and black reformatting Signed-off-by: blisc <blisc@users.noreply.github.com> * add renamed file Signed-off-by: Jason <jasoli@nvidia.com> * Apply isort and black reformatting Signed-off-by: blisc <blisc@users.noreply.github.com> * fix autorefactor errors Signed-off-by: Jason <jasoli@nvidia.com> * fix linting issues Signed-off-by: Jason <jasoli@nvidia.com> * remove unneeded imports inside of audio collection Signed-off-by: Jason <jasoli@nvidia.com> * Apply isort and black reformatting Signed-off-by: blisc <blisc@users.noreply.github.com> * remove torchaudio from more files Signed-off-by: Jason <jasoli@nvidia.com> * update tests Signed-off-by: Jason <jasoli@nvidia.com> * Apply isort and black reformatting Signed-off-by: blisc <blisc@users.noreply.github.com> * change audio codec TA call Signed-off-by: Jason <jasoli@nvidia.com> * update import statement in speechlm2 Signed-off-by: Jason <jasoli@nvidia.com> --------- Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: blisc <blisc@users.noreply.github.com> Co-authored-by: blisc <blisc@users.noreply.github.com> Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>
…5211 Signed-off-by: Jason <jasoli@nvidia.com>
…IDIA-NeMo#15211 (NVIDIA-NeMo#15384) Signed-off-by: Jason <jasoli@nvidia.com>
|
This PR is a breaking change to older models, please take action before it makes it to the next release |
|
Which models is it breaking / how old? |
|
I managed to reproduce it with a model trained using |
|
Further investigation shows that this is reproducible with any model that was trained with |
|
Torchaudio was removed as a dependency. Can you migrate all models to non torchaudio preprocessor? |
|
I don't mind doing that, in fact I stopped using it a while ago, the problem arises when we try to load models that were trained using torchaudio in the preprocessor and that fails, the solution imo would be having a translation code to match the key names in the state dict during the model loading process or a script to convert old .nemo files that used torchaudio to a format that is accepted by the new versions (just modify the parameter names in the state dict) |
|
@MahmoudAshraf97 see if this helps #15437 |
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Removes use of torchaudio.transforms and moves transforms inside of NeMo.
NOTE: we will use torchsquirm in nemo/collections/audio/metrics/squim.py and nemo/collections/tts/models/magpietts_preference_optimization.py
Collection: audio, asr, tts
Changelog
PR Type: