Relax kaldialign pin in ASR requirements to unblock Python 3.14 compatibility#15438
Open
basnijholt wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
Relax kaldialign pin in ASR requirements to unblock Python 3.14 compatibility#15438basnijholt wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
kaldialign pin in ASR requirements to unblock Python 3.14 compatibility#15438basnijholt wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
kaldialign pin in ASR requirements to unblock Python 3.14 compatibility
Author
|
@andrusenkoau Could you share the original reason for pinning |
Collaborator
Hi @basnijholt, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kaldialigninrequirements/requirements_asr.txtfrom<=0.9.1tokaldialignContext
In PR #14775, commit
ce4ad4bchanged this requirement fromkaldialign>=0.9.2tokaldialign<=0.9.1with the message "decrease kaldialign version".I could not find additional rationale in the PR discussion/review thread, so the reason for the cap is currently not documented for downstream maintainers.
Why This Change
kaldialignnow publishes Python 3.14 wheels (e.g.0.9.3, includingcp314).The
<=0.9.1cap blocks those newer releases, which prevents consumers from resolving newer Python-compatible builds.Relaxing the cap allows dependency resolution to use current releases and improves Python 3.14 compatibility.
Request For Context
@andrusenkoau if there was a specific compatibility reason for the
<=0.9.1cap, could you share it here? If needed, I can revise this PR to a softer bound (for example<1) instead of fully unbounded.