Skip to content

Implement workaround for Japanese transcript normalization#15448

Open
subhankar-ghosh wants to merge 2 commits intomainfrom
magpietts_fix_ja_space_bug
Open

Implement workaround for Japanese transcript normalization#15448
subhankar-ghosh wants to merge 2 commits intomainfrom
magpietts_fix_ja_space_bug

Conversation

@subhankar-ghosh
Copy link
Collaborator

Add workaround for Japanese normalizer bug regarding spaces.

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Add workaround for Japanese normalizer bug regarding spaces.

Signed-off-by: Subhankar Ghosh <subhankarg@nvidia.com>
Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @subhankar-ghosh 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Comment on lines +3871 to +3872
if language == "ja":
transcript = transcript.replace(" ", "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you regex all whitespace? Should there be whitespace in Japanese text?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

が新しい日本語対応のを公開し ました。-> This has a single space, no English characters and it breaks.
が新しい日本語対応のモデル  が公開されました。-> This has a tab and it breaks.

This change will remove all spaces, even continuous spaces or tabs.

Google says "Generally, there are no spaces in standard written Japanese; sentences are written as continuous strings of characters. Word boundaries are distinguished by the mix of Kanji (logograms), Hiragana (phonetic), and Katakana, along with grammatical particles."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants