Implement workaround for Japanese transcript normalization#15448
Implement workaround for Japanese transcript normalization#15448subhankar-ghosh wants to merge 2 commits intomainfrom
Conversation
Add workaround for Japanese normalizer bug regarding spaces. Signed-off-by: Subhankar Ghosh <subhankarg@nvidia.com>
Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>
|
[🤖]: Hi @subhankar-ghosh 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
| if language == "ja": | ||
| transcript = transcript.replace(" ", "") |
There was a problem hiding this comment.
Can you regex all whitespace? Should there be whitespace in Japanese text?
There was a problem hiding this comment.
が新しい日本語対応のを公開し ました。-> This has a single space, no English characters and it breaks.
が新しい日本語対応のモデル が公開されました。-> This has a tab and it breaks.
This change will remove all spaces, even continuous spaces or tabs.
Google says "Generally, there are no spaces in standard written Japanese; sentences are written as continuous strings of characters. Word boundaries are distinguished by the mix of Kanji (logograms), Hiragana (phonetic), and Katakana, along with grammatical particles."
Add workaround for Japanese normalizer bug regarding spaces.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information