fix(scheduler): fix lowest common subtree calculation if a preferred level is provided #905

davidLif · 2026-01-20T07:39:10Z

Description

Bug fix: If a preferred topology constraint is set, do not try to find a lowest common subtree (as a part of the calculations optimizations) which is lower then the preferred level.

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

Self-reviewed
Added/updated tests (if needed)
Updated documentation (if needed)

Breaking Changes

Additional Notes

github-actions · 2026-01-20T07:48:31Z

📊 Performance Benchmark Results

Comparing PR (DavidL/35892-fixTopologyPrefferedSharedTopologyBug) vs main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │           pr-bench.txt            │
                                    │     sec/op     │   sec/op     vs base              │
AllocateAction_SmallCluster-4           107.7m ±  0%   107.8m ± 4%       ~ (p=0.310 n=6)
AllocateAction_MediumCluster-4          136.0m ±  2%   136.1m ± 1%       ~ (p=0.818 n=6)
AllocateAction_LargeCluster-4           221.9m ± 14%   222.7m ± 9%       ~ (p=1.000 n=6)
ReclaimAction_SmallCluster-4            102.6m ±  0%   102.7m ± 0%       ~ (p=1.000 n=6)
ReclaimAction_MediumCluster-4           105.1m ±  0%   105.0m ± 0%       ~ (p=0.937 n=6)
PreemptAction_SmallCluster-4            103.3m ±  0%   103.4m ± 0%       ~ (p=0.818 n=6)
PreemptAction_MediumCluster-4           112.5m ±  0%   112.5m ± 0%       ~ (p=0.937 n=6)
ConsolidationAction_SmallCluster-4      113.3m ±  0%   113.4m ± 0%       ~ (p=0.065 n=6)
ConsolidationAction_MediumCluster-4     201.6m ±  1%   202.5m ± 1%       ~ (p=0.132 n=6)
FullSchedulingCycle_SmallCluster-4      104.9m ±  0%   104.9m ± 0%       ~ (p=0.394 n=6)
FullSchedulingCycle_MediumCluster-4     118.6m ±  0%   118.7m ± 1%       ~ (p=0.240 n=6)
FullSchedulingCycle_LargeCluster-4      157.4m ±  1%   156.9m ± 2%       ~ (p=0.394 n=6)
ManyQueues_MediumCluster-4              139.2m ±  1%   138.6m ± 1%       ~ (p=0.818 n=6)
GangScheduling_MediumCluster-4          157.9m ±  2%   157.5m ± 1%       ~ (p=0.937 n=6)
geomean                                 130.1m         130.2m       +0.03%

                                    │ main-bench.txt │            pr-bench.txt             │
                                    │      B/op      │     B/op       vs base              │
AllocateAction_SmallCluster-4           2.115Mi ± 0%    2.115Mi ± 0%       ~ (p=1.000 n=6)
AllocateAction_MediumCluster-4          11.70Mi ± 0%    11.70Mi ± 0%       ~ (p=0.485 n=6)
AllocateAction_LargeCluster-4           41.17Mi ± 0%    41.17Mi ± 0%       ~ (p=0.589 n=6)
ReclaimAction_SmallCluster-4            863.7Ki ± 1%    867.7Ki ± 1%       ~ (p=0.310 n=6)
ReclaimAction_MediumCluster-4           2.737Mi ± 0%    2.738Mi ± 0%       ~ (p=0.132 n=6)
PreemptAction_SmallCluster-4           1008.5Ki ± 1%   1008.7Ki ± 1%       ~ (p=0.394 n=6)
PreemptAction_MediumCluster-4           3.947Mi ± 0%    3.942Mi ± 0%       ~ (p=0.132 n=6)
ConsolidationAction_SmallCluster-4      5.550Mi ± 0%    5.546Mi ± 0%       ~ (p=0.818 n=6)
ConsolidationAction_MediumCluster-4     46.66Mi ± 0%    46.66Mi ± 0%       ~ (p=0.699 n=6)
FullSchedulingCycle_SmallCluster-4      1.343Mi ± 1%    1.343Mi ± 0%       ~ (p=0.818 n=6)
FullSchedulingCycle_MediumCluster-4     6.717Mi ± 0%    6.717Mi ± 0%       ~ (p=0.937 n=6)
FullSchedulingCycle_LargeCluster-4      22.53Mi ± 0%    22.53Mi ± 0%       ~ (p=0.310 n=6)
ManyQueues_MediumCluster-4              16.16Mi ± 0%    16.16Mi ± 0%       ~ (p=0.418 n=6)
GangScheduling_MediumCluster-4          16.88Mi ± 0%    16.88Mi ± 0%       ~ (p=0.240 n=6)
geomean                                 6.225Mi         6.227Mi       +0.03%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            35.40k ± 0%   35.40k ± 0%       ~ (p=0.981 n=6)
AllocateAction_MediumCluster-4           322.0k ± 0%   322.0k ± 0%       ~ (p=0.619 n=6)
AllocateAction_LargeCluster-4            1.386M ± 0%   1.386M ± 0%       ~ (p=0.418 n=6)
ReclaimAction_SmallCluster-4             7.895k ± 0%   7.896k ± 0%       ~ (p=0.565 n=6)
ReclaimAction_MediumCluster-4            24.54k ± 0%   24.54k ± 0%       ~ (p=0.123 n=6)
PreemptAction_SmallCluster-4             10.79k ± 0%   10.79k ± 0%  +0.01% (p=0.048 n=6)
PreemptAction_MediumCluster-4            37.17k ± 0%   37.17k ± 0%       ~ (p=0.136 n=6)
ConsolidationAction_SmallCluster-4       72.35k ± 0%   72.34k ± 0%       ~ (p=0.937 n=6)
ConsolidationAction_MediumCluster-4      681.0k ± 0%   681.0k ± 0%       ~ (p=0.394 n=6)
FullSchedulingCycle_SmallCluster-4       20.71k ± 0%   20.71k ± 0%       ~ (p=0.981 n=6)
FullSchedulingCycle_MediumCluster-4      172.1k ± 0%   172.1k ± 0%       ~ (p=0.513 n=6)
FullSchedulingCycle_LargeCluster-4       720.8k ± 0%   720.8k ± 0%       ~ (p=0.290 n=6)
ManyQueues_MediumCluster-4               360.1k ± 0%   360.1k ± 0%       ~ (p=0.974 n=6)
GangScheduling_MediumCluster-4           590.6k ± 0%   590.6k ± 0%       ~ (p=0.307 n=6)
geomean                                  108.9k        108.9k       +0.00%

Legend

📉 Negative delta = Performance improvement (faster)
📈 Positive delta = Performance regression (slower)
p-value < 0.05 indicates statistically significant change

Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	       9	 112106585 ns/op	 2218266 B/op	   35407 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107971778 ns/op	 2216908 B/op	   35401 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107818651 ns/op	 2216872 B/op	   35404 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107695733 ns/op	 2217261 B/op	   35402 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107806257 ns/op	 2217921 B/op	   35402 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107791726 ns/op	 2228657 B/op	   35404 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134887736 ns/op	12267301 B/op	  321998 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136718583 ns/op	12263981 B/op	  321994 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134149233 ns/op	12263373 B/op	  321990 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137530224 ns/op	12276866 B/op	  321989 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137835453 ns/op	12262998 B/op	  321989 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135533823 ns/op	12266910 B/op	  321995 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 221908847 ns/op	43172390 B/op	 1386293 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 224304879 ns/op	43173216 B/op	 1386296 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 223582398 ns/op	43171904 B/op	 1386281 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 243562607 ns/op	43180897 B/op	 1386301 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 212365027 ns/op	43172665 B/op	 1386285 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 219566066 ns/op	43172230 B/op	 1386287 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102662014 ns/op	  877466 B/op	    7866 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102663961 ns/op	  887100 B/op	    7887 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102719612 ns/op	  889949 B/op	    7897 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102564906 ns/op	  886266 B/op	    7896 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102665392 ns/op	  891140 B/op	    7896 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102601900 ns/op	  889992 B/op	    7897 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105187453 ns/op	 2869530 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105044272 ns/op	 2873370 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105031382 ns/op	 2873399 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105029261 ns/op	 2869381 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105047486 ns/op	 2869580 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105071940 ns/op	 2873488 B/op	   24539 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103318201 ns/op	 1032877 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103406953 ns/op	 1036623 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103323331 ns/op	 1032476 B/op	   10785 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103406949 ns/op	 1043332 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103293961 ns/op	 1032765 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103393580 ns/op	 1032882 B/op	   10788 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112735688 ns/op	 4133938 B/op	   37169 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112154063 ns/op	 4129858 B/op	   37168 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112452028 ns/op	 4133497 B/op	   37167 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112534413 ns/op	 4138377 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112486536 ns/op	 4134120 B/op	   37170 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112367958 ns/op	 4133929 B/op	   37169 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112972097 ns/op	 5815960 B/op	   72344 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113362818 ns/op	 5819179 B/op	   72372 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113411651 ns/op	 5828116 B/op	   72363 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113402241 ns/op	 5814735 B/op	   72339 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 108213400 ns/op	 2217878 B/op	   35406 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108199636 ns/op	 2218208 B/op	   35403 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107522152 ns/op	 2217047 B/op	   35403 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107650586 ns/op	 2217388 B/op	   35401 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107701428 ns/op	 2218118 B/op	   35404 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107478534 ns/op	 2217089 B/op	   35403 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 138071125 ns/op	12284979 B/op	  321999 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136635194 ns/op	12263563 B/op	  321993 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136721200 ns/op	12262939 B/op	  321986 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133749416 ns/op	12263644 B/op	  321990 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135307108 ns/op	12262306 B/op	  321987 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134196984 ns/op	12266496 B/op	  321991 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 223494438 ns/op	43173256 B/op	 1386292 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 216301922 ns/op	43173968 B/op	 1386304 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 252882947 ns/op	43173488 B/op	 1386301 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 232702993 ns/op	43189155 B/op	 1386306 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 220321150 ns/op	43171587 B/op	 1386277 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 214825536 ns/op	43172073 B/op	 1386288 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102634786 ns/op	  881063 B/op	    7864 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102678276 ns/op	  882780 B/op	    7886 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102632768 ns/op	  882324 B/op	    7894 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102696922 ns/op	  886162 B/op	    7896 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102635192 ns/op	  895149 B/op	    7897 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102606578 ns/op	  886202 B/op	    7896 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105138759 ns/op	 2873463 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 104886464 ns/op	 2865503 B/op	   24536 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105034385 ns/op	 2865490 B/op	   24536 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105056706 ns/op	 2869522 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105251312 ns/op	 2869487 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105043989 ns/op	 2869493 B/op	   24538 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103461076 ns/op	 1028783 B/op	   10785 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103481225 ns/op	 1032807 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103279937 ns/op	 1028965 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103298647 ns/op	 1039264 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103351981 ns/op	 1036325 B/op	   10786 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103226273 ns/op	 1032621 B/op	   10786 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112530787 ns/op	 4138520 B/op	   37172 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112059134 ns/op	 4138356 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112634282 ns/op	 4138276 B/op	   37170 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112694353 ns/op	 4133696 B/op	   37168 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112452045 ns/op	 4138491 B/op	   37172 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112414995 ns/op	 4134024 B/op	   37170 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112944656 ns/op	 5810226 B/op	   72282 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113387227 ns/op	 5820936 B/op	   72359 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113323778 ns/op	 5826056 B/op	   72340 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113324080 ns/op	 5819064 B/op	   72377 allocs/op

…d a lowest common subtree (as a part of the calculations optimizations) which is lower then the preferred level.

github-actions · 2026-01-20T09:19:02Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology	86.86% (+0.16%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go	100.00% (ø)	31 (+5)	31 (+5)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go	92.59% (ø)	270	250	20

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common_test.go

…ogyBug

github-actions · 2026-01-20T12:35:31Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology	86.86% (+0.16%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go	100.00% (ø)	31 (+5)	31 (+5)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go	92.59% (ø)	270	250	20

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common_test.go

…ogyBug

github-actions · 2026-01-20T13:19:51Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology	86.86% (+0.16%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go	100.00% (ø)	31 (+5)	31 (+5)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go	92.59% (ø)	270	250	20

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common_test.go

…ogyBug

github-actions · 2026-01-21T11:42:00Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology	86.86% (+0.16%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go	100.00% (ø)	31 (+5)	31 (+5)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go	92.59% (ø)	270	250	20

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common_test.go

…ogyBug

github-actions · 2026-01-25T13:24:35Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology	86.86% (+0.16%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go	100.00% (ø)	31 (+5)	31 (+5)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go	92.59% (ø)	270	250	20

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common_test.go

github-actions · 2026-01-25T13:59:42Z

Backport failed for v0.10, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.10
git worktree add -d .worktree/backport-905-to-v0.10 origin/v0.10
cd .worktree/backport-905-to-v0.10
git switch --create backport-905-to-v0.10
git cherry-pick -x 6b2d46654867517d77b7966b37f79e9af82b9901

davidLif added backport v0.10 backport v0.12 labels Jan 20, 2026

davidLif enabled auto-merge January 20, 2026 07:41

davidLif added 2 commits January 20, 2026 10:48

Bug fix: If a preferred topology constraint is set, do not try to fin…

97b9805

…d a lowest common subtree (as a part of the calculations optimizations) which is lower then the preferred level.

Update changelog

e43663c

davidLif force-pushed the DavidL/35892-fixTopologyPrefferedSharedTopologyBug branch from c65e73f to e43663c Compare January 20, 2026 08:48

Merge branch 'main' into DavidL/35892-fixTopologyPrefferedSharedTopol…

e7e299c

…ogyBug

Merge branch 'main' into DavidL/35892-fixTopologyPrefferedSharedTopol…

29db29c

…ogyBug

Merge branch 'main' into DavidL/35892-fixTopologyPrefferedSharedTopol…

1efb492

…ogyBug

davidLif removed the backport v0.12 label Jan 21, 2026

Merge branch 'main' into DavidL/35892-fixTopologyPrefferedSharedTopol…

8b6165b

…ogyBug

gshaibi approved these changes Jan 25, 2026

View reviewed changes

davidLif added this pull request to the merge queue Jan 25, 2026

Merged via the queue into main with commit 6b2d466 Jan 25, 2026
8 checks passed

davidLif deleted the DavidL/35892-fixTopologyPrefferedSharedTopologyBug branch January 25, 2026 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(scheduler): fix lowest common subtree calculation if a preferred level is provided #905

fix(scheduler): fix lowest common subtree calculation if a preferred level is provided #905

davidLif commented Jan 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 20, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 20, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 21, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 25, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(scheduler): fix lowest common subtree calculation if a preferred level is provided #905

fix(scheduler): fix lowest common subtree calculation if a preferred level is provided #905

Conversation

davidLif commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Changes

Additional Notes

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Benchmark Results

Legend

Uh oh!

github-actions bot commented Jan 20, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 20, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 20, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 21, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 25, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davidLif commented Jan 20, 2026 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading