-
Notifications
You must be signed in to change notification settings - Fork 633
[IT] Improve Italian light on/off test coverage #3659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Italian HassTurnOn tests for cucina, studio and soggiorno
Add Italian HassTurnOff light tests for common room phrases
|
Grazie mille! |
tests/it/light_HassTurnOff.yaml
Outdated
| area: Cucina | ||
| domain: light | ||
| response: Ho spento le luci in cucina | ||
| response: Ho spento le luci in Cucina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be "cucina" lowercase, test is failing on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done it!
Fix response casing in Italian light tests
Fix response casing in Italian light tests
|
Do you receive my correction? |
|
@giuseppeferraiolo yes, but tests are still failing, because we need to change "Soggiorno" in this file to lowercase I can't make changes to your branch because they are disabled, so you have to do it |
I see lowercase in my branch. I newly committed now. |
lowercase/uppercase
lowercase/uppercase
Added Studio in areas.
prettify
|
Finally it's ready to merge. Please test it better next time |
This PR adds missing Italian test coverage for common light on/off commands,
including room-based phrases such as “accendi/spegni la luce in cucina”,
“nello studio”, and “in soggiorno”, as well as contextual “here” commands.