Skip to content

Conversation

@giuseppeferraiolo
Copy link
Contributor

This PR adds missing Italian test coverage for common light on/off commands,
including room-based phrases such as “accendi/spegni la luce in cucina”,
“nello studio”, and “in soggiorno”, as well as contextual “here” commands.

Add Italian HassTurnOn tests for cucina, studio and soggiorno
Add Italian HassTurnOff light tests for common room phrases
@auanasgheps
Copy link
Contributor

Grazie mille!

area: Cucina
domain: light
response: Ho spento le luci in cucina
response: Ho spento le luci in Cucina
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "cucina" lowercase, test is failing on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done it!

Fix response casing in Italian light tests
Fix response casing in Italian light tests
@andreasbrett andreasbrett changed the title Improve Italian light on/off test coverage [IT] Improve Italian light on/off test coverage Jan 2, 2026
@giuseppeferraiolo
Copy link
Contributor Author

Do you receive my correction?

@auanasgheps
Copy link
Contributor

auanasgheps commented Jan 4, 2026

@giuseppeferraiolo yes, but tests are still failing, because we need to change "Soggiorno" in this file to lowercase
https://github.com/OHF-Voice/intents/blob/87d76bce45e9029221f6afb9596110e6f0d317dc/tests/it/light_HassTurnOff.yaml#L24C36-L24C45

I can't make changes to your branch because they are disabled, so you have to do it

@giuseppeferraiolo
Copy link
Contributor Author

@giuseppeferraiolo yes, but tests are still failing, because we need to change "Soggiorno" in this file to lowercase https://github.com/OHF-Voice/intents/blob/87d76bce45e9029221f6afb9596110e6f0d317dc/tests/it/light_HassTurnOff.yaml#L24C36-L24C45

I can't make changes to your branch because they are disabled, so you have to do it

I see lowercase in my branch. I newly committed now.

@auanasgheps auanasgheps merged commit da11a93 into OHF-Voice:main Feb 3, 2026
2 checks passed
@auanasgheps
Copy link
Contributor

auanasgheps commented Feb 3, 2026

Finally it's ready to merge. Please test it better next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants