[Draft] detect/absent: Add error_or option to the absent keyword#14734
Draft
[Draft] detect/absent: Add error_or option to the absent keyword#14734
Conversation
Contributor
|
Why not use the existing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14734 +/- ##
==========================================
- Coverage 82.17% 82.16% -0.01%
==========================================
Files 1008 1008
Lines 263938 263994 +56
==========================================
+ Hits 216897 216920 +23
- Misses 47041 47074 +33
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 29364 |
Contributor
Author
@victorjulien suggested this keyword in the ticket; however, it could be combined with |
Issue: 7114 Add an option for the absent keyword. The error_or option matches when - There has been a content inspection error, such as base64 decode failing - There is no content inspection error and the following content matches
Issue: 7114 Add a way to flag inspection buffer errors. Add a new flag to track those.
Issue: 7114 Detect and flag base64 decode errors; add unit tests to cover base64 decode error handling.
Issue: 7114 Add error_or handling to the engine analyzer.
Issue: 7114
Issue: 7114 Describe the option "error_or" for the absent keyword.
|
Information: QA ran without warnings. Pipeline = 29393 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the error_or option to the absent keyword. This keyword matches when
error_or must be used with a sticky buffer and must have a content keyword following it.
Example:
This alert triggers ifff
file.datacannot be decoded with base64file.datacan be decoded, and the decoded data contains the stringmaliciousLink to ticket: https://redmine.openinfosecfoundation.org/issues/7114
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2897
SU_REPO=
SU_BRANCH=