Doc schema remove obsolete 5267 v1#14736
Closed
catenacyber wants to merge 3 commits intoOISF:mainfrom
Closed
Conversation
Probably a duplicate typo
catenacyber
added
typo/doc update
|
Information: QA skipped due to tag. Set to force a run. Pipeline = skip |
victorjulien
reviewed
Feb 4, 2026
| "from": { | ||
| "type": "string" | ||
| }, | ||
| "has_exe_url": { |
Member
There was a problem hiding this comment.
The support for this was quietly removed in #11225
I did not find any mention of it in the commits or upgrade docs.. we really need to do better here.
Contributor
Author
There was a problem hiding this comment.
And #11225 was adding this do the json schema !..
victorjulien
reviewed
Feb 4, 2026
| "insert_data_overlap_fail": { | ||
| "type": "integer" | ||
| }, | ||
| "insert_list_fail": { |
Member
Contributor
Author
There was a problem hiding this comment.
Thanks, I did not git bisect
victorjulien
approved these changes
Feb 4, 2026
Member
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Much sloppiness exposed here, we need to do better.
Merged
Contributor
Author
Sorry :-/ |
Member
|
Merged in #14750, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5267 + extended cleanup
Describe changes:
@jufajardini I would also remove
extra_float_digitsand every property in pgsql optional_parameters as we have"additionalProperties": true,and we accept arbitrary strings as keysCommand used :
jq '.. | keys? | .[]' etc/schema.json | sort | uniq | grep '"' | cut -d'"' -f2 | while read i; do echo -n $i; git grep $i | wc -l; done | awk '$2 == 1'