Add payload-only-classtypes filtering to suricata conf to filter payl…#14737
Open
Aboussejra wants to merge 1 commit intoOISF:mainfrom
Open
Add payload-only-classtypes filtering to suricata conf to filter payl…#14737Aboussejra wants to merge 1 commit intoOISF:mainfrom
Aboussejra wants to merge 1 commit intoOISF:mainfrom
Conversation
…oad dump by classtype if needed
Aboussejra
requested review from
a team,
jufajardini and
victorjulien
as code owners
5 tasks
victorjulien
requested changes
Feb 3, 2026
Member
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Not convinced the string based design is the best here.
| } | ||
|
|
||
| // Check if classtype in alert matches any in the filter list | ||
| const char *alert_classtype = pa->s->classtype; |
Member
There was a problem hiding this comment.
I'm not too fond of this strcmp loop in a critical path. Can we find a better solution? E.g. a class id in a bitarray or something?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14737 +/- ##
==========================================
- Coverage 82.17% 82.16% -0.02%
==========================================
Files 1008 1008
Lines 263916 263979 +63
==========================================
+ Hits 216868 216890 +22
- Misses 47048 47089 +41
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oad dump by classtype if needed
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2895
SU_REPO=
SU_BRANCH=