Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Jan 18, 2026

Overview

add Mixpanel track event for sizes

close AUTH-2527

{
  "event": "notificationProtocolVisualizationViewportSizes",
  "properties": {
    "time": 1768693194.291,
    "distinct_id": "distinct_id",
    "$browser": "Chrome",
    "$browser_version": 142,
    "$city": "Queens",
    "$current_url": "http://localhost:5173/#/labware",
    "$initial_referrer": "$direct",
    "$initial_referring_domain": "$direct",
    "$insert_id": "insert_id",
    "$lib_version": "2.22.1",
    "$mp_api_endpoint": "api.mixpanel.com",
    "$mp_api_timestamp_ms": 1768693194291,
    "$mp_event_size": 832,
    "$os": "Mac OS X",
    "$region": "New York",
    "$screen_height": 1600,
    "$screen_width": 2560,
    "Left Column Width": 590, // this pr adds
    "Right Column Width": 429, // this pr adds
    "U2E Device Name": "USB 10/100/1000 LAN",
    "U2E IPv4 Address": false,
    "U2E Manufacturer": "Realtek",
    "U2E Product ID": 33107,
    "U2E Serial Number": "000001",
    "U2E Vendor ID": 3034,
    "Window Height": 768, // this pr adds
    "Window Width": 1548, // this pr adds
    "appId": "appid",
    "appMode": "Desktop",
    "appVersion": "version",
    "customLabwareCount": 12,
    "mp_country_code": "US",
    "mp_lib": "web",
    "mp_processing_time_ms": 1768693197273
  }
}

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

add mixpanel track envet for sizes

close AUTH-2527
@koji koji requested a review from jerader January 18, 2026 00:05
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.92%. Comparing base (a59c60f) to head (116430c).
⚠️ Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20633      +/-   ##
==========================================
- Coverage   56.93%   56.92%   -0.02%     
==========================================
  Files        3911     3911              
  Lines      322818   322919     +101     
  Branches    45736    45739       +3     
==========================================
+ Hits       183803   183825      +22     
- Misses     138792   138871      +79     
  Partials      223      223              
Flag Coverage Δ
app 46.26% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rotocolVisualization/VisualizerContainer/index.tsx 64.74% <100.00%> (+2.15%) ⬆️
app/src/redux/analytics/constants.ts 82.69% <100.00%> (+0.22%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@koji koji marked this pull request as ready for review January 20, 2026 14:52
@koji koji merged commit 79da3c3 into edge Jan 20, 2026
60 checks passed
@koji koji deleted the feat_add-mixpanel-event-for-window-size branch January 20, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants