【fleet】support Dpo lora #3617
Merged
【fleet】support Dpo lora #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (26.31%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3617 +/- ##
==========================================
Coverage ? 32.60%
==========================================
Files ? 431
Lines ? 81889
Branches ? 0
==========================================
Hits ? 26701
Misses ? 55188
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
lugimzzz
reviewed
Jan 21, 2026
| model_config.max_sequence_length = data_args.max_seq_len | ||
| model_config._attn_implementation = model_args.attn_impl | ||
| model_config.is_lora = model_args.lora | ||
|
|
Collaborator
There was a problem hiding this comment.
qwen3vl lora也需要fallback，需要确定去掉这个对qwen3vl影响，否则会报错
Contributor
Author
There was a problem hiding this comment.
qwen3vl 本地已验证，没有报错
Contributor
Author
|
/re-run all-failed |
risemeup1
previously approved these changes
Jan 27, 2026
zjjlivein
previously approved these changes
Jan 27, 2026
swgu98
previously approved these changes
Jan 27, 2026
xiaoguoguo626807
dismissed stale reviews from swgu98, zjjlivein, and risemeup1
via
c4254f2
2 tasks
Contributor
Author
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
risemeup1
approved these changes
Jan 28, 2026
zjjlivein
approved these changes
Jan 28, 2026
swgu98
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
testsfolder. If there are codecov issues, please add tests cases first.PR types
Others
PR changes
Others
Description
支持dpo-lora, qwenvl3 lora 使用fleet 组网