Skip to content

Conversation

@xingmingyyj
Copy link
Contributor

【Cherry-Pick】fix ignore_load_opt_and_lr bug (#3675)

fix comm group args

fix

fix

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

save/load support parallel_broadcast and Fix ignore load opt

@paddle-bot
Copy link

paddle-bot bot commented Jan 27, 2026

Thanks for your contribution!

【Cherry-Pick】fix ignore_load_opt_and_lr bug (PaddlePaddle#3675)

fix comm group args

fix

fix

remove unused comments
@xingmingyyj xingmingyyj changed the title 【Cherry-Pick】save/load support parallel_broadcast , Fix ignore load opt and delete load_from_hf branch 【Cherry-Pick】save/load support parallel_broadcast , Fix ignore load opt and delete unused load_from_hf branch Jan 27, 2026
Copy link
Collaborator

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingmingyyj
Copy link
Contributor Author

/re-run all-failed

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 2.27273% with 43 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/v0.4.1@0c1f3e2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/trainer/trainer.py 2.27% 43 Missing ⚠️

❌ Your patch status has failed because the patch coverage (2.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.4.1    #3711   +/-   ##
=================================================
  Coverage                  ?   31.43%           
=================================================
  Files                     ?      418           
  Lines                     ?    69943           
  Branches                  ?        0           
=================================================
  Hits                      ?    21985           
  Misses                    ?    47958           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@From00 From00 merged commit 36f4eef into PaddlePaddle:release/v0.4.1 Jan 27, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants