Fix: Add langchain-core dependency to resolve deprecated import issue #17341
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Latin characters with diacritics (é, è, à, ç, etc.) and French contractions (n'êtes) in word grouping logic of BaseRecLabelDecode.get_word_info(). This fix ensures that French words are no longer split at accented characters during OCR text recognition.
- Moved test_french_accents.py to tests/ directory following project structure - Removed invalid 'FRENCH' prefix from Unicode name check - Unicode standard only uses 'LATIN' prefix for all Latin-based characters - All French accented characters (é, è, à, ç, etc.) are correctly matched - Verified with comprehensive character set including uppercase/lowercase variants
This commit addresses the ModuleNotFoundError for 'langchain.docstore' that occurs in PaddleX's retriever module. The langchain library deprecated the langchain.docstore.document import path in favor of langchain_core.documents. Changes: - Add langchain-core>=0.1.0 to project dependencies in pyproject.toml This ensures compatibility with the current PaddleX dependency while the langchain ecosystem transitions to the new import structure. The fix resolves CI/CD test failures without introducing breaking changes to the PaddleOCR API.
|
Thanks for your contribution! |
Contributor
Author
|
@liuhongen1234567 Hi, Fix made as required in the other PR "Prevent auto-splitting of French accented words in text recognition" |
Member
|
Since PaddleOCR does not directly depend on |
Contributor
Author
Sure thing, I'll submit the PR there 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: ModuleNotFoundError for langchain.docstore
Description
This PR fixes the CI/CD test failure caused by a deprecated langchain import path in the PaddleX dependency.
Problem
The test suite was failing with:
This error occurs in PaddleX's retriever module at
paddlex/inference/pipelines/components/retriever/base.py:25, which uses the deprecated import:Root Cause
The langchain library deprecated the
langchain.docstore.documentimport path and moved it tolangchain_core.documents. The PaddleX dependency still uses the old import path.Reference: https://reference.langchain.com/python/integrations/langchain_google_community/?h=document#langchain_google_community.DocumentAIWarehouseRetriever
Solution
Added
langchain-core>=0.1.0to the project dependencies inpyproject.toml. This provides the new import path that the updated langchain ecosystem expects while maintaining backward compatibility with PaddleX until it updates its import statements.Changes
pyproject.toml:langchain-core>=0.1.0to dependencies listTesting
The fix ensures that:
Impact
Related Issues
Additional Notes
This is a compatibility fix. The long-term solution would be for PaddleX to update its import statements to use the new langchain_core path. Once PaddleX releases an updated version, this dependency addition will remain harmless as it's part of the langchain ecosystem.