Skip to content

Conversation

@ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 29, 2026

Proposed changes

Closes #5764
Instead of installing just nexus/bin files, nexus module files are also copied to the install destination for fully functional nexus scripts like qmca using exactly matched nexus module files.

There are issues remaining around nxs-test copied into the installation. nexus/tests files are not copied.
nexus/install also writes QMCPACK source directory into nxs-test script and make it depending on QMCPACK source.
That can be tackled separately.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@jtkrogel
Copy link
Contributor

jtkrogel commented Feb 2, 2026

Why not just copy the whole Nexus repo? It's not heavy. If you want to avoid risk of becoming unsynced for any reason, just use rsync -a --delete ... instead of cp, etc.

@jtkrogel
Copy link
Contributor

jtkrogel commented Feb 2, 2026

I don't understand your comments regarding nxs-test above. Could you explain further?

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 2, 2026

I don't understand your comments regarding nxs-test above. Could you explain further?

This PR only copiesnexus/nexus/*.py not the rest folder content thus now-test won’t work due to missing files under the test folder.

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 2, 2026

Why not just copy the whole Nexus repo? It's not heavy. If you want to avoid risk of becoming unsynced for any reason, just use rsync -a --delete ... instead of cp, etc.

I’m not comfortable copying the whole nexus folder, existing cache can be outdated. CMakeLists.txt under tests also should not be copied.

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 3, 2026

Superseded by #5778

@ye-luo ye-luo closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete Nexus install, missing library files

2 participants