Skip to content

Conversation

@quapka
Copy link
Contributor

@quapka quapka commented Oct 29, 2025

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In case it's not too late, this PR implements the fix proposed in #4.

Issue Number: #4

What is the new behavior?

Building the project in other than debug mode will with a descriptive and intentional error message.

Does this introduce a breaking change?

  • Yes
  • No

@quapka quapka requested a review from romen as a code owner October 29, 2025 18:08
@romen
Copy link
Member

romen commented Nov 17, 2025

Hi @quapka, sorry it took so long to come to this!

This is great: I already had a commit ready in our private repo, doing this and acknowledging you, but this is even better.

I rebased it on the post-release commit bumping the version to the next release cycle, and merged it as 624e701.

I also noticed in your fork you have more branches and many of them look very interesting.
Please do not let my low responsiveness so far prevent you to contribute more!

@romen romen closed this Nov 17, 2025
@quapka
Copy link
Contributor Author

quapka commented Nov 17, 2025

Hi @romen, thanks.

I've tried to DRY-out the actions, but failed in the end. So, nothing to contribute now.

Here I've just created a simple flake.nix that defines the environment needed to compile the project. Nix is getting more visibility lately, so maybe you'll want this?

@romen
Copy link
Member

romen commented Nov 18, 2025

@quapka so far I kept nix stuff only on the “parent” workspace repo, as I am the only one in the team experimenting with it regularly: https://github.com/qubip/aurora-ib-ws

You can talk me into adding a flake to this repo directly, integrate instead in the workspace repo, or even “do both” (as ensuring the parent flake is in line with your aurora flake and reuses its outputs)

What do you think? Probably we should spawn a separate issue to continue this conversation so it stays documented and findable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants