ROCM-1617 - Resolve potential issues with Drv memcpy tests

[AidanBeltonS]

Motivation

The current CI occationally is flakey with failures due to UB, and correctness issues. This change addresses some of those issues in the memory tests

Technical Details

hipDrvMemcpy2DUnaligned.cc
* Reset parameters before each SECTION
* Free pinned host memory with hipHostFree not hipFree
* srcH and srcD need to check, that they are not nullptr's after malloc. Implemented this using RAII class LinearAllocGuard
hipDrvMemcpy3DAsync.cc
* Passes actually invalid pitch, i.e. MaxPitch + 1
hipDrvMemcpy3DAsync_old.cc
* Handle peer access enable/disable
* Allocate 3D memory correctly, currently missing depth we are just allocating 2D
* Reset parameters between SECTION's
* Construct stream, I think previously it was left uninitialized and all work was on the default stream
* Fix memory leak
hipDrvPtrGetAttributes.cc
* Type mismatchs
* remove incorrect nvidia test, with buffer overflow

JIRA ID

Partial solution: ROCM-1617

Test Plan

NA

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[Copilot]

Pull request overview

This PR resolves various issues in HIP driver memory copy tests including undefined behavior, memory leaks, and correctness problems that were causing CI flakiness.

Changes:

• Fixed memory allocation/deallocation issues (incorrect free functions, missing nullptr checks, memory leaks)
• Added proper parameter resets between test sections to avoid state pollution
• Corrected 3D memory allocation to include depth dimension (was allocating 2D instead of 3D)
• Implemented peer access enable/disable handling and stream initialization
• Fixed type mismatches and removed invalid test cases

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
memcpy2d_tests_common.hh	Added peer access tracking and proper cleanup after device-to-device operations
hipDrvPtrGetAttributes.cc	Fixed type mismatches (unsigned int to int/size_t) and removed invalid NVIDIA-specific test with buffer overflow
hipDrvMemcpy3D_old.cc	Fixed 3D memory allocation, added parameter reset between sections, peer access handling, nullptr checks, and memory leak fixes
hipDrvMemcpy3DAsync_old.cc	Similar fixes as hipDrvMemcpy3D_old.cc plus stream initialization and improved memory management
hipDrvMemcpy3DAsync.cc	Corrected invalid pitch test to actually pass MaxPitch + 1 instead of MaxPitch
hipDrvMemcpy2DUnaligned.cc	Fixed incorrect hipFree calls (should be hipHostFree), added parameter resets, and replaced raw pointers with RAII LinearAllocGuard
hip_test_common.hh	Added PeerAccessGuard RAII class for safe peer access management

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.