Hiprtc amdgcnspirv.offload support #2862
Draft
+202
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --offload-arch=amdgcnspirv with HIP RTC, the triple was identified as "amdgcn-amd-amdhsa--amdgcnspirv" instead of "spirv64-amd-amdhsa--amdgcnspirv".
…xecutable For --offload-arch=amdgcnspirv, modify compileToExecutable to generate a SPIRV wrapped in ELF. hiprtcCompileProgram with --offload-arch=amdgcnspirv as program flags invokes compileToExecutable in this way.
…ith SPIRV Modify IsCodeObjectElf() to accept generic ELF files in addition to AMDGPU ELF files.
…ELF w/ SPIRV to native kernel machine code To create the actual executable to run as one loads hip module data, it is extracted from the ELF and then translated from SPIRV to machine code, hipModuleLoadData with --offload-arch=amdgcnspirv as program flags invokes Program::linkImpl in this way.
jofrn
force-pushed
the
hiprtc-amdgcnspirv.offload
branch
from
39de52a to
a73485f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
Resolves SWDEV-537768.
What type of PR is this? (check all applicable)
What were the changes?
To support SPIRV in hiprtc
-offload-arch=amdgcnspirvpath.Why are these changes needed?
Allows for a SPIRV binary (rather than only ELF) to be loaded via
hipModuleLoadDataby giving it SPIRV -> Relocatable -> Native ELF translation abilities.Updated CHANGELOG?
Added/Updated documentation?
Additional Checks