Fixing aqlprofile ASM statement #2881
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of F16 (half-precision float) instructions in AQL profile integration tests for RDNA3 architectures. RDNA3 GPUs (gfx11xx and gfx12xx) default to Real16 mode, which requires the .set fake16 directive to use legacy F16 instructions.
Changes:
- Added preprocessor macros to detect RDNA3 architectures (gfx11xx and gfx12xx variants)
- Updated inline assembly blocks using F16 instructions to include
.set fake16directive for RDNA3 architectures - Applied fixes to both
iops_kernel_transandiops_kernel1functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+41
| // Helper macro to detect RDNA3 (gfx11xx) architectures | ||
| // These architectures default to Real16 mode and require .set fake16 for legacy F16 instructions |
There was a problem hiding this comment.
The hardcoded list of architecture defines makes this difficult to maintain as new RDNA3 variants are added. Consider checking for a common gfx11 or gfx12 family define if available, or documenting the rationale for this specific list in a comment.
Suggested change
| // Helper macro to detect RDNA3 (gfx11xx) architectures | |
| // These architectures default to Real16 mode and require .set fake16 for legacy F16 instructions | |
| // Helper macro to detect RDNA3 (gfx11xx) architectures. | |
| // These architectures default to Real16 mode and require .set fake16 for legacy F16 instructions. | |
| // | |
| // NOTE: This list is intentionally explicit rather than using a hypothetical common | |
| // "gfx11/gfx12 family" preprocessor macro. Current HIP/Clang toolchains used by this | |
| // test do not provide a stable family-wide define that covers all RDNA3 parts with | |
| // Real16 defaults, so we enumerate the known SKUs individually to avoid mis-detection. | |
| // When adding support for new RDNA3/gfx11/gfx12 variants that behave like these | |
| // architectures, extend the list below with the corresponding __gfxXXXX__ defines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://ontrack-internal.amd.com/browse/SWDEV-576770
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist