feat(styles): add search results classes to fd-list [ci visual]#6180
Merged
mikerodonnell89 merged 5 commits intomainfrom Nov 4, 2025
Merged
feat(styles): add search results classes to fd-list [ci visual]#6180mikerodonnell89 merged 5 commits intomainfrom
mikerodonnell89 merged 5 commits intomainfrom
Conversation
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mikerodonnell89
force-pushed
the
feat/shell-search
branch
2 times, most recently
from
ab7a3af to
dc76f31
Compare
InnaAtanasova
requested changes
Oct 27, 2025
Contributor
There was a problem hiding this comment.
The "Message area" needs some updates. There's a 4px gap between the top and bottom lines. The top line has font weight of 700, the bottom line has color --sapContent_LabelColor.
Missing byline with button:
Can you add in the example a case with 2 buttons:
Missing wrapping and truncation behaviour:
In our example we have:
packages/styles/stories/Components/List/list/standard/search-results.example.html
Outdated
Show resolved
Hide resolved
packages/styles/stories/Components/List/list/standard/search-results.example.html
Outdated
Show resolved
Hide resolved
packages/styles/stories/Components/List/list/standard/search-results.example.html
Outdated
Show resolved
Hide resolved
Contributor
InnaAtanasova
left a comment
InnaAtanasova
left a comment
There was a problem hiding this comment.
It's missing the See more/less functionality (css)
mikerodonnell89
force-pushed
the
feat/shell-search
branch
2 times, most recently
from
c223578 to
60e23b6
Compare
mikerodonnell89
force-pushed
the
feat/shell-search
branch
2 times, most recently
from
67c9fcb to
4299694
Compare
mikerodonnell89
force-pushed
the
feat/shell-search
branch
from
4299694 to
f5cefb6
Compare
packages/styles/stories/Components/List/list/standard/standard-list.stories.js
Outdated
Show resolved
Hide resolved
mikerodonnell89
force-pushed
the
feat/shell-search
branch
from
5fd37b6 to
a976d27
Compare
InnaAtanasova
approved these changes
Nov 4, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6179