Sky culture converter20062025

.clang-format

@@ -247,4 +247,4 @@ WhitespaceSensitiveMacros:
   - NS_SWIFT_NAME
   - PP_STRINGIZE
   - STRINGIZE
-...
+...

.clang-tidy

@@ -1,37 +1,77 @@
 ---
-Checks:                 '*,-google-default-arguments,-fuchsia-*,-zircon-*,-abseil-*,-llvmlibc-*'
-WarningsAsErrors:       ''
-HeaderFilterRegex:      ''
-AnalyzeTemporaryDtors:  false
-FormatStyle:            file
+Checks: >
+  -*, 
+  readability-misleading-indentation,
+  readability-redundant-declaration,
+  readability-redundant-member-init,
+  readability-use-anyofallof,
+  readability-identifier-naming,
+  readability-braces-around-statements,
+  readability-function-cognitive-complexity,
+  readability-magic-numbers,
+  readability-else-after-return,
+  readability-avoid-const-params-in-decls,
+  readability-container-size-empty,
+  readability-redundant-string-cstr,
+  readability-redundant-control-flow,
+  readability-simplify-boolean-expr,
+  readability-uppercase-literal-suffix,
+  readability-static-accessed-through-instance,
+  readability-named-parameter,
+  modernize-use-auto,
+  modernize-use-nullptr,
+  modernize-use-override,
+  modernize-deprecated-headers,
+  modernize-use-using,
+  modernize-avoid-c-arrays,
+  modernize-make-unique,
+  modernize-make-shared,
+  cppcoreguidelines-avoid-magic-numbers,
+  cppcoreguidelines-pro-bounds-constant-array-index,
+  cppcoreguidelines-pro-type-static-cast-downcast,
+  cppcoreguidelines-pro-type-reinterpret-cast,
+  cppcoreguidelines-pro-type-cstyle-cast,
+  cppcoreguidelines-pro-type-member-init,
+  cppcoreguidelines-pro-bounds-pointer-arithmetic,
+  cppcoreguidelines-pro-type-vararg,
+  cppcoreguidelines-no-malloc,
+  cppcoreguidelines-special-member-functions,
+  cppcoreguidelines-avoid-non-const-global-variables,
+  cppcoreguidelines-init-variables,
+  hicpp-no-array-decay,
+  hicpp-signed-bitwise,
+  hicpp-uppercase-literal-suffix,
+  hicpp-use-auto,
+  hicpp-use-nullptr,
+  hicpp-use-override,
+  hicpp-deprecated-headers,
+  hicpp-explicit-conversions,
+  hicpp-multiway-paths-covered,
+  hicpp-no-malloc,
+  hicpp-special-member-functions,
+  hicpp-avoid-goto,
+  performance-for-range-copy,
+  performance-implicit-conversion-in-loop,
+  performance-inefficient-vector-operation,
+  performance-unnecessary-value-param
+WarningsAsErrors: "*"
+HeaderFilterRegex: ".*"
+AnalyzeTemporaryDtors: true
+FormatStyle: file
 CheckOptions:
-  - key:                cert-dcl16-c.NewSuffixes
-    value:              'L;LL;LU;LLU'
-  - key:                cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
-    value:              '1'
-  - key:                google-readability-braces-around-statements.ShortStatementLines
-    value:              '1'
-  - key:                google-readability-function-size.StatementThreshold
-    value:              '800'
-  - key:                google-readability-namespace-comments.ShortNamespaceLines
-    value:              '10'
-  - key:                google-readability-namespace-comments.SpacesBeforeComments
-    value:              '2'
-  - key:                modernize-loop-convert.MaxCopySize
-    value:              '16'
-  - key:                modernize-loop-convert.MinConfidence
-    value:              reasonable
-  - key:                modernize-loop-convert.NamingStyle
-    value:              CamelCase
-  - key:                modernize-pass-by-value.IncludeStyle
-    value:              llvm
-  - key:                modernize-replace-auto-ptr.IncludeStyle
-    value:              llvm
-  - key:                modernize-use-nullptr.NullMacros
-    value:              'NULL'
-  - key:                misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
-    value:              '1'
-  - key:                modernize-use-default-member-init.UseAssignment
-    value:              '1'
-...
-
+  - key: readability-identifier-naming.ClassCase
+    value: CamelCase
+  - key: readability-identifier-naming.MethodCase
+    value: camelBack
+  - key: readability-identifier-naming.VariableCase
+    value: camelBack
+  - key: readability-identifier-naming.ConstantCase
+    value: UPPER_CASE
+  - key: readability-identifier-naming.MacroDefinitionCase
+    value: UPPER_CASE
+  - key: readability-identifier-naming.EnumCase
+    value: CamelCase
+  - key: readability-identifier-naming.EnumConstantCase
+    value: CamelCase
+  - key: readability-braces-around-statements.ShortStatementLines
+    value: 1

.github/workflows/bundle-build.yml

@@ -0,0 +1,96 @@
+name: Bundle Build
+
+on:
+  push:
+
+  pull_request:
+    branches: [ "main" ]
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch: 
+
+env:
+  parallel_processes: 6 # A good default counts is: available Threads + 2
+
+jobs:
+  build:
+    runs-on: windows-latest
+    strategy:
+      matrix:
+        build_type: ["MinSizeRel"]
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Qt
+      uses: jurplel/install-qt-action@v4
+      with:
+        aqtversion: '==3.1.*'
+        version: '6.5.1'
+        host: 'windows'
+        target: 'desktop'
+        cache: true
+        arch: 'win64_msvc2019_64'
+        modules: 'qt3d qtactiveqt qtcharts qtconnectivity qtdatavis3d qtgrpc qthttpserver qtimageformats qtlanguageserver qtlocation qtlottie qtmultimedia qtnetworkauth qtpdf qtpositioning qtquick3dphysics qtquickeffectmaker qtremoteobjects qtscxml qtsensors qtserialbus qtserialport qtspeech qtvirtualkeyboard qtwebchannel qtwebengine qtwebsockets qtwebview debug_info qt5compat qtquick3d qtquicktimeline qtshadertools'
+
+    - name: Cache Inno Setup
+      id: cache-innosetup
+      uses: actions/cache@v4
+      with:
+        path: innosetup.exe
+        key: innosetup-6.4.3
+
+    - name: Download Inno Setup
+      if: steps.cache-innosetup.outputs.cache-hit != 'true'
+      shell: powershell
+      run: |
+        wget -O innosetup.exe "https://jrsoftware.org/download.php/innosetup-6.4.3.exe"
+
+    - name: Install Inno Setup
+      run: |
+        ./innosetup.exe /silent /dir=${{github.workspace}}/innoSetup /CURRENTUSER /NOICONS
+        set innoPath=
+        set PATH=%PATH%;${{github.workspace}}/innoSetup
+
+    # Packages should be automatically downloaded using vcpkg through the toolchain
+    - name: Configure CMake
+      env:
+        CMAKE_PREFIX_PATH: ${{env.QT_ROOT_DIR}}
+      # Choose CMakeLists.text from a specific source directory with -S.
+      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
+      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
+      run: |
+        cmake -B build -S . -DCMAKE_BUILD_TYPE=${{matrix.build_type}} -DCMAKE_INSTALL_PREFIX=stellarium-bin -DSCM_SHOULD_ENABLE_CONVERTER=OFF
+
+    - name: Build
+      # Build your program with the given configuration
+      run: |
+        cmake --build build --config ${{matrix.build_type}} -j ${{env.parallel_processes}} --target install
+
+    - name: Build Installer
+      run: |
+        cmake --build build --config ${{matrix.build_type}} -j ${{env.parallel_processes}} --target stellarium-installer
+
+    # We use the first find as it should only be one
+    - name: Install Stellarium for Bundeling
+      run: |
+        $installer = Get-ChildItem -Path installers -Recurse -Filter 'stellarium-*-qt6-win64.exe' | Select-Object -First 1
+        if ($installer) {
+          New-Item -ItemType Directory -Path stellarium-installer -Force | Out-Null
+          Copy-Item $installer.FullName stellarium-installer\
+
+          $quickInstallScript = "stellarium-installer\quickInstall.bat"
+          $installerRelativePath = ".\" + $installer.Name
+          $quickInstallContent = "`"$installerRelativePath`" /silent /dir=stellarium /CURRENTUSER /NOICONS /LOG=`"installation.log`" /MERGETASKS=`"!desktopicon`""
+          $quickInstallContent += "`r`nmklink stellarium.exe stellarium\stellarium.exe"
+          Set-Content -Path $quickInstallScript -Value $quickInstallContent
+        } else {
+          Write-Error "Installer not found."
+        }
+
+    - name: Deploy Stellarium installer
+      uses: actions/upload-artifact@v4
+      with:
+        name: stellarium-windows-installer
+        path: stellarium-installer
+        retention-days: 3  # Don't store to long as stellarium builds are large

.github/workflows/ci.yml

@@ -9,13 +9,17 @@ on:
   pull_request:
     # The branches below must be a subset of the branches above
     branches: [master]
+    types: [opened, reopened, synchronize, ready_for_review]
+
+env:
+  parallel_processes: 6 # A good default counts is: available Threads + 2
 
 jobs:
   # CI on Linux (Qt5)
   ci-linux-qt5:
     name: "Linux (amd64; qt5)"
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
 
     steps:
     - name: Install dependencies
@@ -42,7 +46,7 @@ jobs:
 
     - name: Compile
       working-directory: build
-      run: make -j3
+      run: make -j ${{env.parallel_processes}}
 
     - name: Run unit tests
       uses: coactions/setup-xvfb@v1
@@ -54,8 +58,8 @@ jobs:
   ci-linux-qt6:
     name: "Linux (amd64; qt6)"
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
-
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
+    
     steps:
     - name: Install dependencies
       run: |
@@ -68,7 +72,7 @@ jobs:
                             qt6-qpa-plugins qt6-image-formats-plugins qt6-l10n-tools qt6-webengine-dev qt6-webengine-dev-tools libqt6charts6-dev \
                             libqt6charts6 libqt6opengl6-dev libqt6positioning6-plugins libqt6serialport6-dev qt6-base-dev libqt6webenginecore6-bin \
                             libqt6webengine6-data libexiv2-dev libnlopt-cxx-dev zlib1g-dev libgl1-mesa-dev libdrm-dev libglx-dev libxkbcommon-x11-dev \
-                            libgps-dev libmd4c-dev libmd4c-html0-dev
+                            libgps-dev libmd4c-dev libmd4c-html0-dev cmake gettext libgettextpo-dev libtidy-dev
 
     - name: Checkout repository
       uses: actions/checkout@v4
@@ -82,7 +86,7 @@ jobs:
 
     - name: Compile
       working-directory: build
-      run: make -j3
+      run: make -j ${{env.parallel_processes}}
 
     - name: Run unit tests
       uses: coactions/setup-xvfb@v1
@@ -94,7 +98,7 @@ jobs:
   ci-linux-qt6-pch:
     name: "Linux (amd64; qt6; core)"
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
 
     steps:
     - name: Install dependencies
@@ -123,12 +127,12 @@ jobs:
               -DUSE_PLUGIN_LENSDISTORTIONESTIMATOR=Off -DUSE_PLUGIN_NEBULATEXTURES=Off -DUSE_PLUGIN_NAVSTARS=Off -DUSE_PLUGIN_NOVAE=Off -DUSE_PLUGIN_OBSERVABILITY=Off \
               -DUSE_PLUGIN_OCULARS=Off -DUSE_PLUGIN_ONLINEQUERIES=Off -DUSE_PLUGIN_POINTERCOORDINATES=Off -DUSE_PLUGIN_PULSARS=Off -DUSE_PLUGIN_QUASARS=Off \
               -DUSE_PLUGIN_REMOTECONTROL=Off -DUSE_PLUGIN_REMOTESYNC=Off -DUSE_PLUGIN_SATELLITES=Off -DUSE_PLUGIN_SCENERY3D=Off -DUSE_PLUGIN_SOLARSYSTEMEDITOR=Off \
-              -DUSE_PLUGIN_SUPERNOVAE=Off -DUSE_PLUGIN_TELESCOPECONTROL=Off -DUSE_PLUGIN_TEXTUSERINTERFACE=Off \
+              -DUSE_PLUGIN_SUPERNOVAE=Off -DUSE_PLUGIN_TELESCOPECONTROL=Off -DUSE_PLUGIN_TEXTUSERINTERFACE=Off -DUSE_PLUGIN_SKYCULTUREMAKER=Off\
               "${{ github.workspace }}"
 
     - name: Compile
       working-directory: build
-      run: make -j3
+      run: make -j ${{env.parallel_processes}}
 
     - name: Run unit tests
       uses: coactions/setup-xvfb@v1
@@ -140,7 +144,7 @@ jobs:
   ci-macos-qt5:
     name: "macOS (x86_64; qt5)"
     runs-on: macos-13
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
 
     # @TODO Enable gpsd on macOS instance for CI testing
     # @BODY At the moment after installing gpsd (brew install gpsd) library can be found by cmake, but not headers! Apparently we should add some magic for environment variables or something else on macOS Catalina to make headers available for cmake/make
@@ -167,7 +171,7 @@ jobs:
 
     - name: Compile
       working-directory: build
-      run: make -j3
+      run: make -j ${{env.parallel_processes}}
 
     - name: Run unit tests
       uses: coactions/setup-xvfb@v1
@@ -179,7 +183,7 @@ jobs:
   ci-macos-intel-qt6:
     name: "macOS (x86_64; qt6)"
     runs-on: macos-13
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
 
     # @TODO Enable gpsd on macOS instance for CI testing
     # @BODY At the moment after installing gpsd (brew install gpsd) library can be found by cmake, but not headers! Apparently we should add some magic for environment variables or something else on macOS Catalina to make headers available for cmake/make
@@ -191,7 +195,7 @@ jobs:
       run: |
         # brew update
         # brew upgrade
-        brew install qt@6 nlopt exiv2
+        brew install qt@6 nlopt exiv2 tidy-html5
 
     - name: Checkout repository
       uses: actions/checkout@v4
@@ -202,11 +206,11 @@ jobs:
         export PATH="/usr/local/opt/qt@6/bin:$PATH"
         mkdir -p build
         cd build
-        cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DSTELLARIUM_RELEASE_BUILD=Off -DENABLE_TESTING=On ${{ github.workspace }}
+        cmake -DCMAKE_PREFIX_PATH="/usr/local/opt/qt@6;/usr/local/opt/tidy-html5" -DCMAKE_BUILD_TYPE=RelWithDebInfo -DSTELLARIUM_RELEASE_BUILD=Off -DENABLE_TESTING=On ${{ github.workspace }}
 
     - name: Compile
       working-directory: build
-      run: make -j3
+      run: make -j ${{env.parallel_processes}}
 
     - name: Run unit tests
       uses: coactions/setup-xvfb@v1
@@ -218,7 +222,7 @@ jobs:
   ci-macos-silicon-qt6:
     name: "macOS (arm64; qt6)"
     runs-on: macos-14
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
 
     # @TODO Enable gpsd on macOS instance for CI testing
     # @BODY At the moment after installing gpsd (brew install gpsd) library can be found by cmake, but not headers! Apparently we should add some magic for environment variables or something else on macOS Catalina to make headers available for cmake/make
@@ -233,7 +237,7 @@ jobs:
       run: |
         # brew update
         # brew upgrade
-        brew install qt@6 nlopt exiv2
+        brew install qt@6 nlopt exiv2 tidy-html5
 
     - name: Checkout repository
       uses: actions/checkout@v4
@@ -248,7 +252,7 @@ jobs:
 
     - name: Compile
       working-directory: build
-      run: make -j3
+      run: make -j ${{env.parallel_processes}}
 
     - name: Run unit tests
       uses: coactions/setup-xvfb@v1
@@ -260,7 +264,7 @@ jobs:
   ci-freebsd-qt6:
     name: "FreeBSD (x86_64; qt5)"
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex') && github.event.pull_request.draft == false"
 
     steps:
     - name: Checkout repository
@@ -284,9 +288,9 @@ jobs:
           mkdir builds
           cd builds
           cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DSTELLARIUM_RELEASE_BUILD=Off -DENABLE_TESTING=On "${{ github.workspace }}"
-          make -j3
+          make -j ${{env.parallel_processes}}
           Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
           sleep 3
           ctest --output-on-failure
           sleep 1
-          pkill Xvfb
+          pkill Xvfb