Skycultures 2.0: Arabic Lunar Mansions

[gzotti]

Description

The Arabic lunar mansions needed some extra definitions to allow variable extent (width) of each mansion. This is now used only in the "arabic_indigenous" SC.
Khalid further refined the definitions of the Arabic skycultures.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update
• Housekeeping

How Has This Been Tested?

Test Configuration:

• Operating system: Windows 11
• Graphics Card: (irrelevant)

Checklist:

• My code follows the code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (header file)
• I have updated the respective chapter in the Stellarium User Guide
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

• Are possibly unused includes removed?

Files matching skycultures/**:

• Did you remember to update skycultures/CMakeLists.txt file respectively to changes in sky cultures?
• Did you remember to define classification parameter in sky cultures (see index.json file)?
• Did you remember to define license parameter in sky cultures (see description.md file)?
• Did you remember to define region parameter in sky culture (see index.json file)?

This is an automatically generated QA checklist based on modified files.

[github-actions]

Hello @gzotti!

Thank you for proposing of the feature.

[alex-w]

Thanks!

[gzotti]

Don't merge yet please. I want to fix the long labels for zodiac/lunar, allow selection of one name part only.

[github-actions]

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions]

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest